This repository was archived by the owner on Nov 19, 2025. It is now read-only.
Fix for state warning in ansible 2.6.5#24
Open
Spreadcat wants to merge 3 commits intoarillso:masterfrom
Open
Conversation
hadret
suggested changes
Sep 24, 2020
Contributor
hadret
left a comment
There was a problem hiding this comment.
This approach won't fly -- logrotate_use_hourly_rotation is a boolean and it's always defined in defaults/main.yml. It will result in always creating link, regardless of the boolean value. I think this approach would be better:
- name: Symlink for hourly rotation
file:
path: "/etc/cron.hourly/logrotate"
src: "/etc/cron.daily/logrotate"
state: link
when: logrotate_use_hourly_rotation | bool
The caveat with this approach is the change of the behavior -- the symlink won't be cleaned up/removed on the logrotate_use_hourly_rotation change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the warning in ansible 2.6.5 regarding the state parameter in the module
file.