feat: add extended positional argument syntax for custom slash commands#149
Open
ariane-emory wants to merge 10 commits intodevfrom
Open
feat: add extended positional argument syntax for custom slash commands#149ariane-emory wants to merge 10 commits intodevfrom
ariane-emory wants to merge 10 commits intodevfrom
Conversation
Add support for ${...} syntax in custom slash command templates:
- ${N} - equivalent to existing $N syntax
- ${N:M} - slice from N to M (non-empty args joined by spaces)
- ${:M} - slice from start to M
- ${N:} - slice from N to end
- ${:} - all arguments
Empty arguments are automatically filtered when joining slices.
The last placeholder (whether $N or ${...}) swallows remaining args.
Also updates Command.hints() to recognize the new syntax.
Fixes #148
${N} without colon now returns only the single argument at position N.
Use ${N:} for open-ended slices that include remaining arguments.
This makes the syntax more explicit:
- ${N} = single argument only (no swallowing)
- ${N:} = slice from N to end (open-ended)
- ${N:M} = slice from N to M
- ${:M} = slice from start to M
- ${:} = all arguments
Swallowing behavior is preserved only for legacy $N syntax.
…opencode into feat/argument-range-syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for ${...} syntax in custom slash command templates:
Empty arguments are automatically filtered when joining slices. The last placeholder (whether$N or $ {...}) swallows remaining args.
Also updates Command.hints() to recognize the new syntax.
Fixes #148
How did you verify your code works?
Manual testing,
bun test,bun typecheck.