feat: allow snapshot config to accept positive integer for retention …#130
Open
ariane-emory wants to merge 15 commits intodevfrom
Open
feat: allow snapshot config to accept positive integer for retention …#130ariane-emory wants to merge 15 commits intodevfrom
ariane-emory wants to merge 15 commits intodevfrom
Conversation
- Changed schema to use .nonnegative() instead of .positive() - Updated cleanup() and track() to treat 0 the same as false - 0 and false both disable snapshots - Positive integers enable snapshots with N-day retention
Replace git gc --prune with direct directory management for snapshot cleanup based on configurable retention period. Snapshots older than the configured number of days are now deleted directly from the filesystem.
Changed snapshot configuration tests to verify the actual retention period calculation logic instead of only checking truthiness. Removed redundant test that looped through multiple integer values.
Added proper type annotations to resolve TS2367 errors in the retention calculation tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…days
What does this PR do?
How did you verify your code works?