Implement retry logic for Etherscan verification submission if contra… #2515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct is not yet indexed
Member
manuelwedler
left a comment
manuelwedler
left a comment
There was a problem hiding this comment.
I think this needs more thought. The way it is implemented now, a retry can block the graceful shutdown logic. See the VerificationService.close method. Ideally, the retries should be cancelled when the graceful shutdown kicks in.
I also noticed that storing external verification results might not be awaited by the graceful shutdown, because the storeExternalVerificationResult is not awaited inside EtherscanVerifyApiService. We might want to change that.
github-project-automation
bot
moved this from Sprint - In Progress
to Sprint - Done
in Sourcify Public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2512