Skip to content

Conversation

@Doryu001
Copy link
Contributor

@Doryu001 Doryu001 commented Nov 7, 2025

Drop unused includes/imports and redundant std::move calls across the frontend/yul helpers flatten CircleCI pagination without functools.reduce and rely on list truthiness directly correct parse_bool to return False for the 'false' input while keeping validation intact

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

Copy link
Member

@clonker clonker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks! This is pretty much the same as #16280 isn't it? In the future, instead of closing one PR and opening a new one, it would be better to just update the old one.
Aside from that - from what I can tell, you are getting rid of the functools.reduce antipattern. Which is good, in principle, but also hardly matters in the bigger context. Unless we are talking hundreds of pages in the pagination, this will have pretty much 0 effect.
So unless I am missing something, I'd rather not change this. What do you think?

@cameel cameel added the refactor label Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants