feat(argocd-image-updater): Make cm and secret names configurable

[KyriosGN0]

Signed-off-by: AvivGuiser [email protected]

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

[mkilchhofer]

Hi @KyriosGN0
May I ask for your motivation to template the ConfigMap/Secret?
Especially the two resources argocd-image-updater-secret and argocd-image-updater-config should be "hardcodeded" since we strictly follow the upstream projects.

And it is mentioned several times inside AUI's documentation

• https://argocd-image-updater.readthedocs.io/en/stable/install/installation/#configure-the-desired-log-level
• https://argocd-image-updater.readthedocs.io/en/stable/install/installation/#configure-api-access-token-secret

[KyriosGN0]

we have a single argocd instance but we have 3 different image updaters, i don't want them to share the same secret/cm as they supposed to be managed in argo and if three different applications will try to control the same cm it won't work
@mkilchhofer

[KyriosGN0]

@mkilchhofer i understand that you follow the upstream project, however i belive that in this case we preserve the purpose of those cm by adding the suffixes to the end of the templated name

[mkilchhofer]

@mkilchhofer i understand that you follow the upstream project, however i belive that in this case we preserve the purpose of those cm by adding the suffixes to the end of the templated name

My only concern is that the name changes depending on the helm command our users are using (helm's release-name). E.g.:

• helm install aui argo/argocd-image-updater -> with your implementation, the CMs are then named:
  • aui-argocd-image-updater
  • aui-argocd-image-updater-sshconfig
  • aui-argocd-image-updater-config
• helm install image-updater argo/argocd-image-updater -> with your implementation, the CMs are then named:
  • image-updater-argocd-image-updater
  • image-updater-argocd-image-updater-sshconfig
  • image-updater-argocd-image-updater-config

Maybe using 3 top-level variables with a static name would fit better? Opinions, @yu-croco @jmeridth @tico24 @mbevc1 ?

[KyriosGN0]

@mkilchhofer im probably missing something, what is the issue with those names being different ? the deployment will just pull the new names (with their data unchanged)

[KyriosGN0]

Hey @mkilchhofer is there any info I can give to expedite the decision ?

[KyriosGN0]

hey @mkilchhofer any updates? sorry for nagging

[mbevc1]

@mkilchhofer i understand that you follow the upstream project, however i belive that in this case we preserve the purpose of those cm by adding the suffixes to the end of the templated name

My only concern is that the name changes depending on the helm command our users are using (helm's release-name). E.g.:

* `helm install aui argo/argocd-image-updater` -> with your implementation, the CMs are then named:
  
  * **aui**-argocd-image-updater
  * **aui**-argocd-image-updater-sshconfig
  * **aui**-argocd-image-updater-config

* `helm install image-updater argo/argocd-image-updater` -> with your implementation, the CMs are then named:
  
  * **image-updater**-argocd-image-updater
  * **image-updater**-argocd-image-updater-sshconfig
  * **image-updater**-argocd-image-updater-config

Maybe using 3 top-level variables with a static name would fit better? Opinions, @yu-croco @jmeridth @tico24 @mbevc1 ?

Oh, totally missed this tag 😄

I like that suggestion and makes sense @mkilchhofer .

[KyriosGN0]

hey @mkilchhofer, sorry for nagging again, are there any updates? anything i should do ?

[KyriosGN0]

Hey @mkilchhofer , another hopeful ping

[mkilchhofer]

@KyriosGN0 @yu-croco @jmeridth @mbevc1
I implemented a suggestion in c26278d. Let me know what you think :)

[mbevc1]

Thanks @mkilchhofer - looks good!

[mkilchhofer]

@tico24 WDYT? :) are you okay with this?

[tico24]

Approved but you'll need to rebase.