Skip to content

Commit

Permalink
feat: add field to disable/enable metrics (#1380)
Browse files Browse the repository at this point in the history
* feat: add field to disable/enable metrics

Signed-off-by: saumeya <[email protected]>

* fixes

Signed-off-by: saumeya <[email protected]>

* bundle fix

Signed-off-by: saumeya <[email protected]>

* review changes

Signed-off-by: saumeya <[email protected]>

---------

Signed-off-by: saumeya <[email protected]>
  • Loading branch information
saumeya authored May 27, 2024
1 parent 4047a69 commit a051fbd
Show file tree
Hide file tree
Showing 7 changed files with 40 additions and 2 deletions.
2 changes: 2 additions & 0 deletions api/v1alpha1/argocd_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,8 @@ type KustomizeVersionSpec struct {
type ArgoCDMonitoringSpec struct {
// Enabled defines whether workload status monitoring is enabled for this instance or not
Enabled bool `json:"enabled"`
// DisableMetrics field can be used to enable or disable the collection of Metrics on Openshift
DisableMetrics *bool `json:"disableMetrics,omitempty"`
}

// ArgoCDNodePlacementSpec is used to specify NodeSelector and Tolerations for Argo CD workloads
Expand Down
7 changes: 6 additions & 1 deletion api/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions api/v1beta1/argocd_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,8 @@ type KustomizeVersionSpec struct {
type ArgoCDMonitoringSpec struct {
// Enabled defines whether workload status monitoring is enabled for this instance or not
Enabled bool `json:"enabled"`
// DisableMetrics field can be used to enable or disable the collection of Metrics on Openshift
DisableMetrics *bool `json:"disableMetrics,omitempty"`
}

// ArgoCDNodePlacementSpec is used to specify NodeSelector and Tolerations for Argo CD workloads
Expand Down
7 changes: 6 additions & 1 deletion api/v1beta1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions bundle/manifests/argoproj.io_argocds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,10 @@ spec:
description: Monitoring defines whether workload status monitoring
configuration for this instance.
properties:
disableMetrics:
description: DisableMetrics field can be used to enable or disable
the collection of Metrics on Openshift
type: boolean
enabled:
description: Enabled defines whether workload status monitoring
is enabled for this instance or not
Expand Down Expand Up @@ -7956,6 +7960,10 @@ spec:
description: Monitoring defines whether workload status monitoring
configuration for this instance.
properties:
disableMetrics:
description: DisableMetrics field can be used to enable or disable
the collection of Metrics on Openshift
type: boolean
enabled:
description: Enabled defines whether workload status monitoring
is enabled for this instance or not
Expand Down
8 changes: 8 additions & 0 deletions config/crd/bases/argoproj.io_argocds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1054,6 +1054,10 @@ spec:
description: Monitoring defines whether workload status monitoring
configuration for this instance.
properties:
disableMetrics:
description: DisableMetrics field can be used to enable or disable
the collection of Metrics on Openshift
type: boolean
enabled:
description: Enabled defines whether workload status monitoring
is enabled for this instance or not
Expand Down Expand Up @@ -7947,6 +7951,10 @@ spec:
description: Monitoring defines whether workload status monitoring
configuration for this instance.
properties:
disableMetrics:
description: DisableMetrics field can be used to enable or disable
the collection of Metrics on Openshift
type: boolean
enabled:
description: Enabled defines whether workload status monitoring
is enabled for this instance or not
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,10 @@ spec:
description: Monitoring defines whether workload status monitoring
configuration for this instance.
properties:
disableMetrics:
description: DisableMetrics field can be used to enable or disable
the collection of Metrics on Openshift
type: boolean
enabled:
description: Enabled defines whether workload status monitoring
is enabled for this instance or not
Expand Down Expand Up @@ -7956,6 +7960,10 @@ spec:
description: Monitoring defines whether workload status monitoring
configuration for this instance.
properties:
disableMetrics:
description: DisableMetrics field can be used to enable or disable
the collection of Metrics on Openshift
type: boolean
enabled:
description: Enabled defines whether workload status monitoring
is enabled for this instance or not
Expand Down

0 comments on commit a051fbd

Please sign in to comment.