Skip to content

Update repositories.txt #6198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

daonguyen207
Copy link

No description provided.

@daonguyen207 daonguyen207 reopened this Apr 15, 2025
@github-actions github-actions bot added the topic: submission Add library to the list label Apr 15, 2025
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/daonguyen207/FontMaker:

Linting library in FontMaker
ERROR: .exe file(s) found. Presence of these files blocks addition to the Library Manager index:
         FontMaker/VN_font_maker.exe                                                            
       (Rule LS007)                                                                             
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in FontMaker/examples/MakeFont_demo

Linter results for project: no errors or warnings

-------------------

Linting sketch in FontMaker/examples/MakeFont_demo2

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @daonguyen207
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 self-assigned this Apr 15, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @daonguyen207. Thanks for your interest in contributing to the Arduino Library Manager.

I see the bot reported a problem with your submission that will block its acceptance:

ERROR: .exe file(s) found. Presence of these files blocks addition to the Library Manager index:
         FontMaker/VN_font_maker.exe                                                            

Please fix the problem so we can proceed with your submission.

You will need to do the following things:

  1. Delete the file VN_font_maker.exe from the repository.
  2. Bump the value of the version field in the library's library.properties metadata file.
  3. Create a new release or tag in the library repository.
  4. Add a comment here in the pull request thread that mentions @ArduinoBot.

After that, the automated checks will run again. Once those are passing, your library will be automatically added to Library Manager.

It will be more appropriate to distribute this file independently from the Arduino library. Ideally, you would create a separate dedicated library for the tool, and publish the source code in that repository. Alternatively, you can distribute the executable file as a GitHub release asset:

https://docs.github.com/en/repositories/releasing-projects-on-github/about-releases

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Apr 15, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of a tidy repository, I'm going to close this due to lack of activity.

@daonguyen207 if you ever resolve the issues reported by the bot, please submit another pull request to add the library.

I'll continue to monitor this thread, so feel free to let me know if you have any questions or concerns.

@per1234 per1234 closed this Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for information More information must be provided before work can proceed topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants