-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update repositories.txt #6198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repositories.txt #6198
Conversation
❌ ERROR: Arduino Lint found errors with https://github.com/daonguyen207/FontMaker:
|
Thanks for your interest in contributing to the Arduino Library Manager index @daonguyen207 After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @daonguyen207. Thanks for your interest in contributing to the Arduino Library Manager.
I see the bot reported a problem with your submission that will block its acceptance:
ERROR: .exe file(s) found. Presence of these files blocks addition to the Library Manager index:
FontMaker/VN_font_maker.exe
Please fix the problem so we can proceed with your submission.
You will need to do the following things:
- Delete the file
VN_font_maker.exe
from the repository. - Bump the value of the
version
field in the library'slibrary.properties
metadata file. - Create a new release or tag in the library repository.
- Add a comment here in the pull request thread that mentions @ArduinoBot.
After that, the automated checks will run again. Once those are passing, your library will be automatically added to Library Manager.
It will be more appropriate to distribute this file independently from the Arduino library. Ideally, you would create a separate dedicated library for the tool, and publish the source code in that repository. Alternatively, you can distribute the executable file as a GitHub release asset:
https://docs.github.com/en/repositories/releasing-projects-on-github/about-releases
If you have any questions or concerns, please let me know.
Regards, Per
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of a tidy repository, I'm going to close this due to lack of activity.
@daonguyen207 if you ever resolve the issues reported by the bot, please submit another pull request to add the library.
I'll continue to monitor this thread, so feel free to let me know if you have any questions or concerns.
No description provided.