-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dropdown to Legend for dataPointThreshold #32
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 87.71% 87.71%
=======================================
Files 1 1
Lines 57 57
Branches 12 12
=======================================
Hits 50 50
Misses 3 3
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Nice! |
@SvenRosvall that is fair enough, as a lazy bum who never titles their plots, I did not anticipate it could be an issue. |
Looks good. Thanks @ignis-sec . |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
In the meantime, I've created a couple videos to guide my students through editing the Serial Plotter's JavaScript source to manually adjust the number of points in their Plotter history. I figured I'd post them here in case they're useful to anyone: Changing the Serial Plotter history length in the Arduino IDE on a Mac Changing the Serial Plotter history length in the Arduino IDE on Windows |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
If anyone wants something quick and dirty which 1) increases the maximum number of data points to 500 and 2) increases the number of lines you can draw to 20, using the matplotlib Then download this file: main.35ae02cb.chunk.js.txt, remove the .txt file extension so it's just I'm sad that it's come to this, but oh well. |
Hey everyone,
I stumbled upon arduino-ide/#803 which has been unresolved since Feb 2, 2022. This pull request addresses that issue.
I added a small dropdown to the Legend component which allows modification of the
dataPointThreshold
, which is used to determine the maximum number of datapoints that will be shown in the serial plotter.This pull request introduces:
dataPointThreshold
that sets the initial value of the variable. (Default set to 50, which was the previous hardcoded value)dataPointThreshold
attribute.dataPointThreshold
attribute.Tested with the master branch of arduino/arduino-ide, found no potential issues.