Skip to content

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 3, 2025

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Adds the Windows/ARM64 pair to the list of supported tools "flavor".

What is the current behavior?

Windows/ARM64 is not supported, there is no way to add support for such hardware combination.

What is the new behavior?

Windows/ARM64 is supported.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

@cmaglie cmaglie self-assigned this Nov 3, 2025
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Nov 3, 2025
per1234
per1234 previously requested changes Nov 3, 2025
@per1234 per1234 added os: windows Specific to Windows operating system architecture: arm64 Specific to 64 bit ARM host architecture architecture: arm Specific to ARM host architecture topic: package-management Related to the packaging and managing of the platform/libraries labels Nov 3, 2025
@cmaglie cmaglie force-pushed the add_win_arm32_host branch from 60c3494 to b101264 Compare November 3, 2025 17:28
@per1234 per1234 dismissed their stale review November 4, 2025 10:01

Requested change has been made. Thanks!

@cmaglie cmaglie force-pushed the add_win_arm32_host branch from b101264 to e8a71d0 Compare November 4, 2025 16:15
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.36%. Comparing base (b1ae171) to head (e8a71d0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3035      +/-   ##
==========================================
- Coverage   69.36%   69.36%   -0.01%     
==========================================
  Files         241      241              
  Lines       18585    18587       +2     
==========================================
  Hits        12892    12892              
- Misses       4496     4497       +1     
- Partials     1197     1198       +1     
Flag Coverage Δ
unit 69.36% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

architecture: arm Specific to ARM host architecture architecture: arm64 Specific to 64 bit ARM host architecture os: windows Specific to Windows operating system topic: code Related to content of the project itself topic: package-management Related to the packaging and managing of the platform/libraries type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants