Skip to content

Improvements for CurieBLE library #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

biagiom
Copy link
Contributor

@biagiom biagiom commented Sep 2, 2016

  • Add some improvements to sketches of CurieBLE library : add the line while(!Serial) ; in order to wait for the Serial port to connect since Arduino/Genuino 101 has native USB port;
  • Update the keyword.txt file of CurieBLE library;
  • Improve BLEAttribute class of CurieBLE library

russmcinnis and others added 4 commits August 31, 2016 14:47
Since Arduino/Genuino 101 uses USB native port, wait for the Serial port
to open before executing the sketch to not lose serial data already sent
to the Serial monitor

Signed-off-by: Biagio Montaruli <[email protected]>
- Add CurieBLE Datatype
- Add new methods : "end" and "setDeviceName"
- Remove inexistent methods :  "str", "data" and "length"
- Add two new constants from BLEcommon.h file header :
  "BLE_MAX_ATTR_DATA_LEN" and "BLE_DEVICE_NAME_DEFAULT_PREFIX"

Signed-off-by: Biagio Montaruli <[email protected]>
Signed-off-by: Biagio Montaruli <[email protected]>
@eriknyquist
Copy link
Contributor

You've changed many files from other libraries here besides BLE. Please remove these files, and add one PR per library.

@biagiom
Copy link
Contributor Author

biagiom commented Sep 7, 2016

Hi @eriknyquist,
sorry for my mistake, I have split the changes over different pull requests :

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants