BLE central Role implementation and peripheral refactor #239
Conversation
| bt_addr_le_t *addr = (bt_addr_le_t *)user_data; | ||
| int i; | ||
|
|
||
| pr_debug(LOG_MODULE_APP, "[AD]: %u data_len %u\n", type, data_len); |
There was a problem hiding this comment.
Can we replace all calls to pr_debug with Serial.println, please?
(Just in the example code-- users won't know what it is).
There was a problem hiding this comment.
Ok... We need to distinguish the difference between pr_debug and Serial.print. Somehow, need to make user to understand that pr_debug is for debugging purposes that log messages go out to another serial port. Serial.print is the standard IO serial output for most users. Any suggestions on how to make that clear? May be a comment in the code? That would be a whole lot of comments. May be rename the routine a bit more obvious?
There was a problem hiding this comment.
In the example sketches. I think we didn"t expose the pr_debug interface. I modified all pr_debug in example sketch.
|
Hi @sgbihu, can you please clean up the history? Remove the merge commit, and please make one commit for each change, e.g. one for BLE central implementation and one for the peripheral refactor. |
|
@sgbihu Please crush the commits into one and rebase to the top of master. The branch has conflicts and cannot be merged at this point. |
Need update the BLE's FW first. @kevin306 has build this FW.
@SidLeung