Skip to content

Add DMA support to I2S #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2016
Merged

Add DMA support to I2S #233

merged 1 commit into from
Jul 12, 2016

Conversation

calvinatintel
Copy link
Contributor

libarc32drv_arduino101.a updated. Replaces PR #230.
@bigdinotech @linrjing Please give me a good description of the changes to be put into the git commit.

@linrjing
Copy link

linrjing commented Jul 8, 2016

@calvinatintel The description of the git commit can be "I2S DMA implement: supplement library and example". Now the codes have been updated on my feature/i2s_dma branch, please merge it with your branch. The changes are: (1)combine I2SDMA with the existing I2S library;(2)Tx side does not need to add 2 extra buffer;(3)after TX-DMA transfer completed, 4 zero would be pushed into the TX FIFO to make sure all expected data have been transmitted to RX side.

@linrjing
Copy link

@xieqi @sgbhu @SidLeung the original request is closed. Calvin helped make a new one here.

@calvinatintel
Copy link
Contributor Author

Added the latest change from linrjing.
@bigdinotech Please test. Once it's confirmed to work, I'll squash the two commits into one.

@linrjing
Copy link

@calvinatintel @bigdinotech currently the code is only for the sample resolution = 32 bit.

@SidLeung
Copy link
Contributor

@calvinatintel The Flex China team is planning to make the implementation to fix the range the sampling resolutions (24, 16, 8 bits). I suppose it would be cleaner if we first let this commit emerge to the trunk first, fork a branch, implement the extra supporting resolutions, push, and merge again. Please advise.

@calvinatintel
Copy link
Contributor Author

@SidLeung Would that break the main repo? If you'd like, I can put it on a branch and you can fork that.

@calvinatintel
Copy link
Contributor Author

About to merge. @bigdinotech Can you confirm?

@bigdinotech
Copy link
Contributor

@calvinatintel ready for merge

@calvinatintel calvinatintel merged commit ecee2e9 into arduino:master Jul 12, 2016
@calvinatintel
Copy link
Contributor Author

Squashed and merged

@calvinatintel calvinatintel deleted the i2s-dma branch July 12, 2016 20:50
@SidLeung
Copy link
Contributor

Thanks @calvinatintel and @bigdinotech. Flex China can now do a fork and add in the new implementation..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants