Fixes location of high card size bits in V2.00 CSD #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SD card size is encoded in 22 bits in the V2.00 CSD block. Due to the way bits are numbered in the spec and C bitfields are laid out on little-endian systems, the 6-bit `c_size_high` field must be listed before the `reserved3` dummy field to include the low 6 bits of the byte. This bug only affected cards over 32GiB in size, as the `c_size_high` field is zero on smaller cards anyway.
|
Hey @pmj, TravisCI finished with status TravisBuddy Request Identifier: f3452ad0-c994-11e9-a673-e3b5aa05dde7 |
|
@pmj the Travis CI build failure is caused by a change in the arduino-cli installation system, which broke our Travis CI configuration. So that error is not caused by anything you did in this PR (though it's possible the CI build could find another problem if it was working). For any maintainers of this repo who might be listening, that issue would be fixed by #67. That PR is ready to merged. |
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the size of large cards was reported incorrectly by
struct CSDV2/csd2_t.The SD card size is encoded in 22 bits in the V2.00 CSD block. Due to the way bits are numbered in the spec and C bitfields are laid out on little-endian systems, the 6-bit
c_size_highfield must be listed before thereserved3dummy field to include the low 6 bits of the byte.This bug only affected cards over 32GiB in size, as the
c_size_highfield is zero on smaller cards anyway.