Abstract calls to digitalWrite and pinMode from the outside "world" by making virtual protected methods#27
Open
DrItanium wants to merge 1 commit intoarduino-libraries:masterfrom
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After seeing the Adafruit RGBLCDShield I wanted to do the same thing over SPI (using an MCP23S17) but found that the LiquidCrystal library is written to favor code duplication over inheritance. After doing some experiments I found that only digitalWrite and pinMode need to become virtual inside the class. This change does not break the external interface nor internal design in any way.