Set scope of enum values to enum class #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: imperfection
There was a problem hiding this comment.
Pull Request Overview
This PR confines the scope of enum values by converting the unscoped enum to a scoped enum class.
- Updated UFile.cpp to reference enum values using FileMode::VALUE.
- Modified Types.h to declare FileMode as an enum class.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/UFile.cpp | Updated enum value usage to use scoped enum class syntax |
| src/Types.h | Converted enum FileMode to enum class for better scoping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52. It does so by confining the scope of the enum values to the enum class. This would only break compatibility for boards using old toolchains, namely AVR boards which are not supported by this library anyway. I can't think of any side effects.