Qspi formatter #32
Open
Qspi formatter #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ 838aba2
Click for full report table
Click for full report CSV |
Comment on lines
44
to
47
| if (_otaData.size() < 5 * 1024 * 1024) { | ||
| return false; | ||
| } | ||
| Serial.println("OTA partition size: " + String((unsigned int)_otaData.size())); |
There was a problem hiding this comment.
Should we print the size of the partition before returning error? this should provide better feedback to the user. We can apply the same procedure to all the other partitions. Probably we could just need 3MB for the ota, instead of 5.
Suggested change
| if (_otaData.size() < 5 * 1024 * 1024) { | |
| return false; | |
| } | |
| Serial.println("OTA partition size: " + String((unsigned int)_otaData.size())); | |
| Serial.print("OTA partition size: " + String((unsigned int)_otaData.size())); | |
| if (_otaData.size() < 5 * 1024 * 1024) { | |
| Serial.println(" ERROR: partition size too small"); | |
| return false; | |
| } | |
| Serial.println(); |
andreagilardoni
approved these changes
May 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 29.85% 29.85%
=======================================
Files 27 27
Lines 1819 1819
=======================================
Hits 543 543
Misses 1276 1276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I kept the prints in a separate commit only for testing purpose. I will remove them before merge the PR. |
|
Memory usage change @ be0c44b
Click for full report table
Click for full report CSV |
|
Memory usage change @ 05e7299
Click for full report table
Click for full report CSV |
fabik111
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a class to handle common QSPI operations