PE-6873: setup integration tests flutter #1882

thiagocarvalhodev · 2024-10-03T12:13:39Z

--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/11k462n72fjso

…flutter

- fixes integration test issues - add gh action

github-actions · 2024-10-03T14:13:29Z

Visit the preview URL for this PR (updated for commit 58793af):

https://ardrive-web--pr1882-pe-6873-setup-integr-n3e6ffi6.web.app

_{(expires Fri, 29 Nov 2024 14:41:08 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0}

finished writing DSL API fixed unit tests implement several tests

add key to seedphrase

add keys

set nexus 6

- mock downloader - fix tests android

fix delay and add test for web

increase timeouts

comment broken tests

kunstmusik · 2024-11-15T21:05:57Z

scripts/run_integration_tests.sh

+#!/bin/bash
+
+# Store the JSON value in a variable to handle it more cleanly
+JSON_VALUE='{"d":"boMCYRnKbWMZ2iKZtdWlNtMzQqk8rw6gNqT6l_l5VgdXnQ-dtxPhrgwJ0sGi8k5gyDTaMY-5ICjF4YNiUL-ugQjRccT0YritisWuTHt5hes-FuTiZXjjxMS3cuOMiGIZYz2R10RK3SR5vmejn85A5PULF4n8jngiftsgQtLXRg3287jUZYcFg7k7c4sJPxS2FbtiZu5JfnWUJ0SXALRAWTnV4M6bTZ7KY42MFyk5cNGc8Z-Xj9greDtS9BpalyRGxH1VI7jC8ZGcwUGpURd4qBREMu4qsNPxg44Ne9dS4ccvXY27ZXXnbzaDIkU0IrP7hNzUmmkhNNht-5pmUgdqu1C5SR201bPjfRv05QEnqvQBCDVLiPiaMy72pGA76hWcJeK3YY05kNaoyjge1M5auTK_HyvyVb2-G1Q1zUMBKvAmQk9DCpxOP0KZaQGAbpPGKFjciZOFj7c-UnDcc1f-cQ-XL_fZEmzW3lA1WvkuBMFnkVI-hOieOj77wRD_mtnkKVHP1w3La5KLVSDfRKTmXvh1CB201fzToCLoPxFX64CcluTvY4WUsXT15ioQWzWf47NGtQxrL5MWxIltfxyAvfYHTJbwqRz60GnmRQPf7HOroVWoCIOntUN98veWA79826qgG-tN36_ixosZTMRTWILAHz1td43ZYUgyRS4_MsE","dp":"yFGRrngGu1Bx3ym9fa9UwzsBaWnT1YDuJAfsW6t7Vg3pBT33B25RYtFso5JxuHlM221GkANetiYdFDeQgvxn40vrwF0ArwGbCTNPkz4nL6QQuJqzLS0sHaUnN9aeKu0_OTgJunJaUzpNHC-Urk2_dWXT9RUtEiuOWYMbUUZE9Xro-427_Lmi5u1p7YmHzf94vcX_Huuhzti-j7OmbPNm1D9JvOuFPS127PlqbSNNxBDOk4WTnpTfaAThNbwRcRuaLmRcyw-x3TtFJ_GgrixWlpOn0HvCiBYXjYv97UMQb7DgHXGukZfn8SEK_frBd4Ywi5jLmVsdh8b_jiqrh6NzFQ","dq":"a_FulDO2kAb414eJAH_PuM2LDM358kzH4WJuu7WmcTUy6euipYpP8kEEdKa2TEPXTcLn1MW9NffU1t8jdEuIjP1_QOxDwFsIWtjvZOyi3lFDmFTSBYCTkKMEfnUdghm7RX_4hk2EeolzUgbms-j2buiJnEaSyeyVKYpMLh4C5N0loRaPEApx2dx7fZKxlvW40_9hu7xTjBCOD401Jpo5fHGbjOTOFaEYAdsIzHzGNYcVzCrs0DF47h7Fc6GKeNcgbyKjdmZ0FloA0u0SqtWOuH0e1mMzi0tYlFU7lvBbqJCg7Tw68Wb4NJR-GoyKesV5wvIkLFGIIeVdOTBuu_vaQQ","e":"AQAB","kty":"RSA","n":"uJJ0n3kA1Gdi_VCpQqT_ZyIlncCilDGTyfadE7Ppw1uUuQOr6SaFukHQFIisx7Gg2GxdkbtH-LSfWyKGDhrSVkSzS5AkKqxxYfwXtYi6pXqFGkWUcsp1n-sZQhgb2AMknwVorQDL-WtnM6Bl7Tknh69P4hM7tdBoUxLV3jM2s-L2QEx2JrJBGdOhuIouua89tNqG-5F1--xJ4f6huWfroPkoNG3-nk-XocsuAvUYixxTUahGCZn8qZAR2IaKoXk6QDjzozCHjpCqDyAP_RUYycC4Ldb2O81-Z6ZXbvBIMC-16zVzT-n0cmQDtfE4KFhL8cEDpgG-9Ly-USkWXe4hHSzBYJlW453-jj6g2W6qx-9WDT41RHamjGLRdgxHmoAtA1fkNfwVnjFtLOB48POpYwy0ehANW0GVBC_9QLj71lEgHgXU3V2VJDcjTkn7jgx166JHbpBqt3yuX72HoU-DYGDSWhU3zxQUtsY7gQ6rlUdNG0vpJQM4sg7v05g3RzYrFSqkW9fb6aTXZHqqBktTgThqlyvky-NOlm_zr93TTnKpzzGNIrkOyT-GbtOl9hoeaYWwcqiSvHW9Cpj1pDUefhmWtHx-28UDRmvAOFd15xI7ptPcMA0U6JLQt1zxe9XGfRPnXeTDhYIYtmWMDjZRoeimankehknBQSlXT55BFBc","p":"4erWLhivIvz4TVa9dFhG0HOwCSRl7-f6-2xQ_IPATiOVGsRUn9Uc7RvlknzKv2Qb4V2eSTL-yVHjS85Pi69S9MCUo18sdF1Qh3dm5gL2WNFPJTEhzUK1EGFcwB37oLxh_HIurm0fzOsN0l9PNlnQww63KU4lu8OCAue3hlAyPNZktWg7tll4pLEC30Cnk_EswDELX9DHGRmLSUr-N-4B7ZGH9G2h7lQrV4XYcTm1tskQRTw_lDGzhJ2qHaLXMIMVM_axOaV0za67ST4a6nd3zI4lJ8qw1uDx7FvgO-rTlYT1Ft4KA7zi_IdMSssKa3-FtwtXG57QE_epgF5sVojQ7Q","q":"0SY5r13Plt5m6-aS1La82yppy-AU1LKyHtY45thL2-FFvtauBqMo56qtVVZN42BrqvIduhu_DyzjSkNJiDoaV7hnKb6ki7y8Wd0zkkFznCA59Qs4JXBTcgCk8iWCef_66HiZHVnvl3orzZRpEsR_kz8n_6Nadqu1kkgYpX8J86X7oIveYoYwtrky0OEdIu5wc7XPhilJ7tXQSdVoxzNYkpyjtmAdBXFzTp2B35aLZoyPCmt7PYEor4dK-j2Azh61NYxfIUF41MD2aPm-yc-DIj01rDdLrK0y28Z6ZonzHDAGw-oFrHUNh3upKnb0rBRB8NTxdOb3bZMBcTVXxL4Mkw","qi":"WdBCzzpGjI2gBWC5xLfo3-QUvNO-ilnDZ2Sw8W8IvmlnocsKRnjvi4mrmxabFuRwSog2D9XHzPIsLHeScgD0HOmV4uTYzExEkwXjKmUVUhVdHPbWGEHV6lh50frbfp8kiNP-8P7yF1firrMtFQaxwxXJhPm64SCxkQ9oR1ZRMgG_JVbb9ksHvIFVKsvRdhVpfz6n2i729XTXhK0dhOyHCYwRz9113P-aitA2CrmJ3UGVY9NDUl5v_c_0siOj_sEYxHn9cHdv2wZTBK7UGmOyKsTngJsS7kyd4qYIEuBBwHn2rU-y-7Rmyw0qtshMjT1MimGl29ETb65w0ORjtk61yg"}'


This seems like a bad idea to have here; why not use an environment variable that can be defined as a github secret?

Or put it into a file in this folder and read it in as a variable in the shell script

kunstmusik · 2024-11-15T21:08:20Z

README.md

@@ -1,4 +1,4 @@
-# ArDrive Web
+****# ArDrive Web


This looks like a typo but could you confirm?

kunstmusik · 2024-11-15T23:00:41Z

lib/arns/domain/arns_repository.dart

@@ -187,6 +187,10 @@ class _ARNSRepository implements ARNSRepository {
    String address, {
    bool update = false,
  }) async {
+    if (!sdk.isArioSDKSupportedOnPlatform()) {


Curious, as I haven't seen rest of code, but it seems like this could be an issue where a user might be on a platform and see no records (thinking they're gone) vs disabling ant feature or showing user message that it's not supported on platform). Want to make sure this isn't hiding that latter scenario and potentially getting users worried.

kunstmusik · 2024-11-15T23:18:41Z

lib/authentication/login/views/prompt_wallet_view.dart

This looks like feature-work outside of integration test support. Could you give me a summary of what changed here?

kunstmusik · 2024-11-15T23:38:38Z

lib/blocs/drives/drives_cubit.dart

@@ -111,6 +111,10 @@ class DrivesCubit extends Cubit<DrivesState> {

      _promptToSnapshotBloc.add(SelectedDrive(driveId: selectedDriveId));

+      if (isClosed) {


Is this a bug fix of some sort?

kunstmusik · 2024-11-15T23:39:09Z

lib/blocs/hide/global_hide_bloc.dart

@@ -17,6 +17,10 @@ class GlobalHideBloc extends Bloc<GlobalHideEvent, GlobalHideState> {
        _driveDao = driveDao,
        super(const GlobalHideInitial(userHasHiddenDrive: false)) {
    _userPreferencesRepository.watch().listen((userPreferences) async {
+      if (isClosed) {


I'm seeing this added in a few places but am unsure what it's doing

- re-enable commented tests - fix issue with duplicated keys for drives - fix folder tests

thiagocarvalhodev added 2 commits October 2, 2024 09:56

implement first integration terst

efdc8ce

Merge branch 'integration-test' into PE-6873-setup-integration-tests-…

155462d

…flutter

thiagocarvalhodev self-assigned this Oct 3, 2024

thiagocarvalhodev changed the base branch from dev to master October 3, 2024 12:14

test(onboarding)

50ee5ea

- fixes integration test issues - add gh action

thiagocarvalhodev changed the base branch from master to dev October 3, 2024 13:58

thiagocarvalhodev added 3 commits October 3, 2024 10:58

Update pr.yaml

b5ff776

Update pr.yaml

4ffbf96

Update pr.yaml

5684059

thiagocarvalhodev and others added 20 commits October 3, 2024 11:18

Update pr.yaml

22b1378

Update pr.yaml

e493f9b

Update pr.yaml

9d219da

Update pr.yaml

5fcb80b

use safari

65ada48

Update app_test.dart

752a7f4

Update app_test.dart

bac452a

Merge branch 'dev' into PE-6873-setup-integration-tests-flutter

505080e

Merge branch 'dev' into PE-6873-setup-integration-tests-flutter

79e22a5

feat(integration test)

194c05f

finished writing DSL API fixed unit tests implement several tests

Update pubspec.yaml

289c9b3

Create run_integration_tests_fvm.sh

b3fee4f

Update pubspec.yaml

d3ea9e1

Update import_wallet_modal.dart

343455c

add key to seedphrase

Update side_bar.dart

97a1f8d

add keys

Update side_bar.dart

febba1f

add helper to select drive

cc2410d

Update dsl.dart

c618b2e

add key to profile card

b2efb4f

test(Logout and Snapshots): implemented test

64cbdcc

thiagocarvalhodev added 19 commits November 13, 2024 11:06

Update run_integration_tests_android.sh

2443abe

set pixel 6 as the correct device

fb5e251

Update pr.yaml

52a8b97

set nexus 6

test(mobile)

ad97e4c

- mock downloader - fix tests android

tests(android)

9a3e47e

fix delay and add test for web

update ardrive io

4020a64

fix multiple scroll

86ed4c2

fix sync cubit closed

ec3797f

Update sync_cubit.dart

6199e30

minor fixes for android tests

89ef4cf

increase timeouts

943e4c7

Update login_tests_mobile.dart

fd9c415

increase timeouts

test(android)

42daf84

comment broken tests

remove profile argument

4122739

Update login_tests_mobile.dart

6dbe9d5

add logout tests

c62f2d5

update tests on mobile

424cee2

Update app_test.dart

e3d98b0

Update app_test.dart

aae8d49

kunstmusik reviewed Nov 15, 2024

View reviewed changes

README.md

@@ -1,4 +1,4 @@

# ArDrive Web

****# ArDrive Web

Copy link

Contributor

kunstmusik Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a typo but could you confirm?

kunstmusik reviewed Nov 15, 2024

View reviewed changes

thiagocarvalhodev added 5 commits November 22, 2024 08:47

Merge branch 'dev' into PE-6873-setup-integration-tests-flutter

d14b694

test

070af56

- re-enable commented tests - fix issue with duplicated keys for drives - fix folder tests

Update login_tests_mobile.dart

5958d45

dont show congestioi warnign

bdf81cd

split web and android tests

58793af

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PE-6873: setup integration tests flutter #1882

PE-6873: setup integration tests flutter #1882

thiagocarvalhodev commented Oct 3, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Oct 3, 2024 •

edited

Loading

kunstmusik Nov 15, 2024

kunstmusik Nov 15, 2024

kunstmusik Nov 15, 2024

kunstmusik Nov 15, 2024

kunstmusik Nov 15, 2024

kunstmusik Nov 15, 2024

kunstmusik Nov 15, 2024

		@@ -111,6 +111,10 @@ class DrivesCubit extends Cubit<DrivesState> {

		_promptToSnapshotBloc.add(SelectedDrive(driveId: selectedDriveId));

		if (isClosed) {

PE-6873: setup integration tests flutter #1882

Are you sure you want to change the base?

PE-6873: setup integration tests flutter #1882

Conversation

thiagocarvalhodev commented Oct 3, 2024 • edited by github-actions bot Loading

github-actions bot commented Oct 3, 2024 • edited Loading

kunstmusik Nov 15, 2024

Choose a reason for hiding this comment

kunstmusik Nov 15, 2024

Choose a reason for hiding this comment

kunstmusik Nov 15, 2024

Choose a reason for hiding this comment

kunstmusik Nov 15, 2024

Choose a reason for hiding this comment

kunstmusik Nov 15, 2024

Choose a reason for hiding this comment

kunstmusik Nov 15, 2024

Choose a reason for hiding this comment

kunstmusik Nov 15, 2024

Choose a reason for hiding this comment

thiagocarvalhodev commented Oct 3, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Oct 3, 2024 •

edited

Loading