chore(deps): use system.text.json instead of newtonsoft.json throughout #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stijnmoreels
added
dependencies
✅ Deploy Preview for arcus-messaging canceled.
|
fgheysels
reviewed
Feb 11, 2025
|
|
||
| <!-- TODO: will be removed in v3.0 --> | ||
| <PackageReference Include="System.Text.Json" Version="[8.0.5,10.0.0)" Condition="'$(TargetFramework)' != 'net8.0'" /> | ||
| <!-- TODO: will be removed in v3.0 --> |
There was a problem hiding this comment.
What do you mean ? Why will we remove this dependency in a later version ?
There was a problem hiding this comment.
As it is only used by .NET Standard and.NET 6. And we are migrating away from them, I believe.
There was a problem hiding this comment.
It's included by default in .NET 8, but not in the other frameworks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Microsoft's built-in
System.Text.Jsoninstead of addingNewtonsoft.Jsonreference in all Messaging-projects.This is part of the lightweight exercise described in #470 where dependencies are being investigated on their added-value and maintainence cost.