Skip to content

feat: compatibility with axallocator#2

Merged
ZR233 merged 2 commits intoarceos-hypervisor:mainfrom
AsakuraMizu:pr/compat
Mar 5, 2026
Merged

feat: compatibility with axallocator#2
ZR233 merged 2 commits intoarceos-hypervisor:mainfrom
AsakuraMizu:pr/compat

Conversation

@AsakuraMizu
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds compatibility with the axallocator crate by replacing the locally-defined allocator traits (BaseAllocator, ByteAllocator, PageAllocator, IdAllocator, AllocError, AllocResult) with re-exports from axallocator = "0.2". This enables the crate to interoperate with the broader axallocator ecosystem.

Changes:

  • Replaces locally-defined traits and error types in src/lib.rs with pub use axallocator::{...} re-exports
  • Adds BaseAllocator implementation for SlabByteAllocator to satisfy the trait requirement from axallocator
  • Updates test assertions from assert_eq!(..., Err(...)) to assert!(matches!(...)) for improved ergonomics

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/lib.rs Removes locally-defined trait/type definitions and replaces them with pub use axallocator::{...}
src/slab/slab_byte_allocator.rs Adds BaseAllocator impl for SlabByteAllocator and imports it directly from axallocator
Cargo.toml Adds axallocator = "0.2" as a required dependency; removes trailing blank lines
tests/integration_test.rs Converts two assert_eq! error assertions to assert!(matches!(...)) form
tests/dma32_pages_test.rs Consolidates two-step error assertions into a single assert!(matches!(...))

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ZR233 ZR233 merged commit 7b1a2ea into arceos-hypervisor:main Mar 5, 2026
8 checks passed
@ZR233 ZR233 mentioned this pull request Mar 5, 2026
Copilot AI added a commit that referenced this pull request Mar 5, 2026
Co-authored-by: AsakuraMizu <17076564+AsakuraMizu@users.noreply.github.com>
ZR233 added a commit that referenced this pull request Mar 5, 2026
* Initial plan

* chore: bump version to 0.2.0

Co-authored-by: ZR233 <34859362+ZR233@users.noreply.github.com>

* chore: remove deprecated bench feature

Co-authored-by: ZR233 <34859362+ZR233@users.noreply.github.com>

* docs: complete CHANGELOG for 0.2.0 with entries from PRs #1 and #2

Co-authored-by: AsakuraMizu <17076564+AsakuraMizu@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ZR233 <34859362+ZR233@users.noreply.github.com>
Co-authored-by: AsakuraMizu <17076564+AsakuraMizu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants