Skip to content

Commit

Permalink
Disable iterator refresh for CoalescingIterator in TestIterateAgainst…
Browse files Browse the repository at this point in the history
…Expected (facebook#12723)

Summary:
Pull Request resolved: facebook#12723

`CoalescingIterator` doesn't support `Refresh` currently; the patch adds a check that was missing from facebook#12721 to disable this operation when multi-CF iterators are in use in the stress test.

Reviewed By: jaykorean

Differential Revision: D58053334

fbshipit-source-id: 3146f0e7e87230b49b244cecdfcee345c0ce78fa
  • Loading branch information
ltamasi authored and facebook-github-bot committed Jun 1, 2024
1 parent fc59d8f commit 023a808
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions db_stress_tool/no_batched_ops_stress.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2116,9 +2116,10 @@ class NonBatchedOpsStressTest : public StressTest {
op_logs += "P";
}

// Write-prepared and Write-unprepared do not support Refresh() yet.
// Write-prepared/write-unprepared transactions and multi-CF iterator do not
// support Refresh() yet.
if (!(FLAGS_use_txn && FLAGS_txn_write_policy != 0) &&
thread->rand.OneIn(2)) {
!FLAGS_use_multi_cf_iterator && thread->rand.OneIn(2)) {
pre_read_expected_values.clear();
post_read_expected_values.clear();
// Refresh after forward/backward scan to allow higher chance of SV
Expand Down

0 comments on commit 023a808

Please sign in to comment.