Skip to content

Commit

Permalink
formatting revisions
Browse files Browse the repository at this point in the history
  • Loading branch information
jordaniza committed Nov 1, 2024
1 parent 3978ddb commit cc8a8d2
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion audits/AUDIT_REPORT.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ Aragon Audits were conducted by various team members.

| Severity | Issue | Status | Comment or PR |
| ------------ | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------ | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| U | New Note-1: Effective voting power after the invocation of function beginWithdrawal() |
| Acknowledged | This is correct and is acknowledged in the same manner as HAL-12. The voting power of votes in the withdrawal queue is active until the end of the current interval, but it cannot be used as the NFT is held by the escrow, so in the current implementation we don't believe this is a problem. Blocksec is correct to acknowledge that this should be addressed in future implementations. |
| U | New Note-2 | Acknowledged | Allowing the users to change votes during the voting period is intended behaviour in this implementation. |
| U | New Question-1 | Acknowledged | The purpose of the warmup period is to function as a minimum buffer before users can vote. In the current implementation, voting power starts accumulating from the start of the upcoming deposit interval (weekly by default), but to avoid someone opportunisitically locking 1 second before voting starts, we add a minimum period where they cannot vote. The intended behaviour is that the voting power _should_ still accumulate during this time. |
Expand Down

0 comments on commit cc8a8d2

Please sign in to comment.