Merge branch 'deploy/mode' of https://github.com/aragon/ve-governance …

…into deploy/mode

DEPLOYMENT.md

@@ -0,0 +1,32 @@
+```yaml
+  Deploying from: 0x5445DD0EB655AA1479aE0Db281ff1413f6317C87
+  Using production parameters
+
+  Chain ID: 34443
+  Factory: 0x9Ee58D5510bd5270D9195B75f166681353D4C603
+
+  DAO: 0xcF2c9A22B58f125f929Cb8e8b29A6d7e2C4287fF
+
+  Plugins
+  - Multisig plugin: 0x0eB63a3565942D16C1c1211bD78F1B3Dcfe1A254
+
+  - Using token: 0xDfc7C877a950e49D2610114102175A06C2e3167a
+    Gauge voter plugin: 0x71439Ae82068E19ea90e4F506c74936aE170Cf58
+    Curve: 0x69E57EE7782701DdA44b170Df5b1244C6F02e89b
+    Exit Queue: 0x915e50A7C53e05F72122bC883309a812A90bA163
+    Voting Escrow: 0xff8AB822b8A853b01F9a9E9465321d6Fe77c9D2F
+    Clock: 0x66CC481755f8a9d415e75d29C17B0E3eF2Af70bD
+    NFT Lock: 0x06ab1Dc3c330E9CeA4fDF0C7C6F6Fb6442A4273C
+
+  - Using token: 0x7c86a44778c52a0AAD17860924b53bf3f35Dc932
+    Gauge voter plugin: 0x2aA8A5C1Af4EA11A1f1F10f3b73cfB30419F77Fb
+    Curve: 0xf597bcF98E79A3B4c92FA70Eb0c6C47DA0f84Fba
+    Exit Queue: 0x1c9B7bD4b3684A0c34Bd9A9b3f7F2dFC8fD81826
+    Voting Escrow: 0x9c2eFe2a1FBfb601125Bb07a3D5bC6EC91F91e01
+    Clock: 0x6d1D6277fBB117d77782a85120796BCb08cAae8a
+    NFT Lock: 0x19d1c7958b2CacBc796b51b98F7d86ccaa6950eE
+
+  Plugin repositories
+  - Multisig plugin repository (existing): 0x7553E6Fb020c5740768cF289e603770AA09b7aE2
+  - Gauge voter plugin repository: 0x2Eb02698a45BCb579D85102ef87442fAC2049B7D
+  ```

Makefile

@@ -19,6 +19,7 @@ test-unit :; forge test --no-match-path "test/fork/**/*.sol"
 
 # Fork testing - mode sepolia
 ft-mode-sepolia-fork :; forge test --match-contract TestE2EV2 \
+	--fork-block-number 19879000 \
 	--rpc-url https://sepolia.mode.network \
 	-vv
 
@@ -71,11 +72,13 @@ deploy-preview-mode :; forge script script/Deploy.s.sol:Deploy \
 	--private-key $(DEPLOYMENT_PRIVATE_KEY) \
 	-vvvvv
 
-deploy-mode :; forge script script/Deploy.s.sol:Deploy \
-	--rpc-url https://mainnet.mode.network \
-	--private-key $(DEPLOYMENT_PRIVATE_KEY) \
-	--broadcast \
-	--verify \
-	--etherscan-api-key $(ETHERSCAN_API_KEY) \
-	-vvv
+
+ deploy-mode :; forge script script/Deploy.s.sol:Deploy \
+     --rpc-url https://mainnet.mode.network \
+     --private-key $(DEPLOYMENT_PRIVATE_KEY) \
+     --broadcast \
+     --verify \
+     --verifier blockscout \
+     --verifier-url https://explorer.mode.network/api\? \
+     -vvv
 

README.md

@@ -71,19 +71,19 @@ Check the `Makefile` for examples of deployments on different networks.
 
 ### Deployment Checklist
 
-- [] I have reviewed the parameters for the veDAO I want to deploy
-- [] I have reviewed the multisig file for the correct addresses
-  - [] I have ensured all multisig members have undergone a proper security review and are aware of the security implications of being on said multisig
-- [] I have updated the `.env` with these parameters
-- [] I have updated the `CurveConstantLib` and `Clock` with any new constants.
-- [] All my unit tests pass
-- [] I have run a fork test in `fork-deploy` mode against the OSx contracts on my target testnet
-- [] I have deployed my contracts successfully to a target testnet
-- [] I have confirmed my tests still work in `fork-existing` mode with the live tokens and the factory.
-- [] I have run the same workflow against the mainnet I wish to deploy on
-- [] I have previewed my deploy
-- [] My deployer address is a fresh wallet or setup for repeat production deploys in a safe manner.
-- [] My wallet has sufficient native token for gas
+- [x] I have reviewed the parameters for the veDAO I want to deploy
+- [x] I have reviewed the multisig file for the correct addresses
+  - [x] I have ensured all multisig members have undergone a proper security review and are aware of the security implications of being on said multisig
+- [x] I have updated the `.env` with these parameters
+- [x] I have updated the `CurveConstantLib` and `Clock` with any new constants.
+- [x] All my unit tests pass
+- [x] I have run a fork test in `fork-deploy` mode against the OSx contracts on my target testnet
+- [x] I have deployed my contracts successfully to a target testnet
+- [x] I have confirmed my tests still work in `fork-existing` mode with the live tokens and the factory.
+- [x] I have run the same workflow against the mainnet I wish to deploy on
+- [x] I have previewed my deploy
+- [x] My deployer address is a fresh wallet or setup for repeat production deploys in a safe manner.
+- [x] My wallet has sufficient native token for gas
 
 ### Manual from the command line