Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move subgraph #8

Merged
merged 31 commits into from
Mar 25, 2024
Merged

feat: move subgraph #8

merged 31 commits into from
Mar 25, 2024

Conversation

jordaniza
Copy link

@jordaniza jordaniza commented Mar 12, 2024 •
edited by jira bot
Loading

This PR moves the tokenVoting subgraph files from OSx over.

In doing so it:

  • Adapts the Schema
  • Updates imports and directories
  • Fixes a couple of tests
  • Fetches the plugin addresss data from the commons configs

Task ID: OS-482

jordaniza added 17 commits March 13, 2024 15:59
@jordaniza
schema: prune native, some unused entities
c8ff627
@jordaniza
feat: removed unneeded erc20 constructs
cdf1bfd
@jordaniza
f: cleanup method-classes of outdated token contracts
5d966e6
@jordaniza
mv: renamed dao to daoAddress inside schema
275b93a
@jordaniza
lint: apply linting recommendations
11f365d
@jordaniza
lint: linting with prettier
c3b25b2
@jordaniza
experiment: simplify id creation
dd871c3
@jordaniza
fix: use legacy tokenVotingPlugin id generation
5c81d35
@jordaniza
docs: update id of plugin comment to reflect legacy move
73e2986
@jordaniza
Merge branch 'develop' into f/subgraph-code-move
cb728c9
@jordaniza
Merge branch 'f/import-plugin-repo-improvements' into f/subgraph-code…
2a2f540 
…-move
@jordaniza
fix: merge conflicts on import-plugin-repo.ts
9f9cf27
@jordaniza
tests: use legacy plugin id in tests
a6afbd3
@jordaniza
Merge branch 'develop' into f/subgraph-code-move
22267cc
@jordaniza
Merge branch 'f/tests-refactor' into develop
f2bceb7
@jordaniza
Merge branch 'develop' into f/subgraph-code-move
cf97a18
@jordaniza
Merge branch 'develop' into f/subgraph-code-move
36b9552
@heueristik heueristik changed the title F/subgraph code move feat: move subgraph Mar 15, 2024
heueristik added a commit that referenced this pull request Mar 15, 2024
@heueristik
Merge pull request #8 from aragon/fix/add-missing-migration-import
7477f69 
Add missing migration import for setup processing
heueristik

This comment was marked as outdated.

Sign in to view

heueristik

This comment was marked as outdated.

Sign in to view

@heueristik heueristik dismissed their stale review March 15, 2024 11:44

Let's first merge #13

@jordaniza jordaniza requested review from heueristik and Rekard0 March 15, 2024 13:00
@jordaniza jordaniza changed the base branch from f/tests-refactor to develop March 15, 2024 13:58
clauBv23
clauBv23 approved these changes Mar 25, 2024
View reviewed changes
Copy link

@clauBv23 clauBv23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jordaniza jordaniza merged commit 84154c3 into develop Mar 25, 2024
5 checks passed
@heueristik heueristik deleted the f/subgraph-code-move branch March 25, 2024 15:46
@jordaniza jordaniza restored the f/subgraph-code-move branch March 27, 2024 13:31
@novaknole novaknole deleted the f/subgraph-code-move branch November 5, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clauBv23 clauBv23 clauBv23 approved these changes

@heueristik heueristik heueristik approved these changes

@Rekard0 Rekard0 Awaiting requested review from Rekard0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jordaniza @Rekard0 @heueristik @clauBv23