Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix isGranted #618

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix isGranted #618

merged 1 commit into from
Oct 29, 2024

Conversation

Rekard0
Copy link
Contributor

@Rekard0 Rekard0 commented Oct 29, 2024

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-?

Type of change

See the framework lifecycle in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.
  • I have created a follow-up task to update the Developer Portal with the changes made in this PR.

@novaknole novaknole merged commit 2f4ae4c into feature/pm-condition-remove-restriction Oct 29, 2024
22 of 24 checks passed
novaknole added a commit that referenced this pull request Oct 30, 2024
@novaknole @Rekard0
condition restrictions (#617)
c951efe 
* condition restrictions

* fix isGranted (#618)

---------

Co-authored-by: Rekard0 <[email protected]>
novaknole added a commit that referenced this pull request Nov 5, 2024
@novaknole @Rekard0
deploying executor and always true condition (#616)
5e34b7b 
* deploying executor and always true condition

* condition restrictions (#617)

* condition restrictions

* fix isGranted (#618)

---------

Co-authored-by: Rekard0 <[email protected]>

* remove alwaystruecondition deployment

* remove .only

* fix broken imports (#620)

* uncomment

---------

Co-authored-by: Rekard0 <[email protected]>
Rekard0 added a commit that referenced this pull request Nov 15, 2024
@Rekard0 @novaknole @clauBv23
OS-1462 feature/update dao facotry to return plugin and support no pl…
16c4d4c 
…ugin daos (#619)

* deploying executor and always true condition

* condition restrictions (#617)

* condition restrictions

* fix isGranted (#618)

---------

Co-authored-by: Rekard0 <[email protected]>

* remove alwaystruecondition deployment

* remove .only

* feature/update dao facotry to return plugin and support no plugin dao creation

* fix comment

* feat: return permission and set all pemission and shadow createDao

* feat: improve gas efficiency

* feat add tests

* fix: comment

* feat: redesign with only one function

* fix: remove unncesary files and import

* update: changelog

* feat: cache apply permission

* feat: improve some test checks (#622)

* fix: formating

---------

Co-authored-by: Giorgi Lagidze <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novaknole novaknole novaknole approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rekard0 @novaknole