Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extended PM with permission owner and delegation capabilities #604

Open
wants to merge 95 commits into
base: develop
Choose a base branch
from
Open

feat: Extended PM with permission owner and delegation capabilities #604

Changes from 2 commits
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
7d338df
Extended PM with permission manager/owner and delegation capabilites
nivida Aug 28, 2024
7876fd5
error handling improved
nivida Aug 28, 2024
45fef46
PR comments and more applied
nivida Aug 29, 2024
6e97176
PM.removeOwner fixed
nivida Aug 29, 2024
9a9ebce
added missing counter++ in pm._createPermission and renamed onlyPermi…
nivida Aug 29, 2024
503f6e1
missing comments to the events declarations added
nivida Aug 29, 2024
3b76ccc
modifier comment added for ownerAuth and other comments improved
nivida Aug 29, 2024
a1f81f1
correct initial bitmap defined in PM._createPermission
nivida Aug 29, 2024
75cc4f5
applyTarget methods updated to have a ROOT fallback
nivida Aug 29, 2024
e136441
allowedContract removed
nivida Aug 29, 2024
afc4fb7
PM._isPermissionFrozen updated
nivida Aug 29, 2024
0819fc5
codestyle++
nivida Aug 29, 2024
916df92
apply target method efficiently
novaknole Aug 29, 2024
dfc2e4e
merge conflict fixed
novaknole Aug 29, 2024
19e2104
correct error type for PM.applyMultiTargetPermissions
nivida Aug 29, 2024
92581ba
root+owner case added to PM.ownerAuth
nivida Aug 29, 2024
228fb10
owner permission check clean up
nivida Aug 29, 2024
3f14f95
ownerAuth clean up
nivida Aug 29, 2024
0af5955
passing of the Operation does simplify ownerAuth
nivida Aug 29, 2024
0eb4e29
codestyle++
nivida Aug 29, 2024
836af08
missing zero flag check added
nivida Aug 29, 2024
99e7046
_checkOwner optimized for the case when the permission isnt created a…
nivida Aug 29, 2024
beeba1b
further efficiency improvements for PM._checkOwner
nivida Aug 29, 2024
8b183ed
obviously not needed if removed
nivida Aug 29, 2024
bef54c8
error types cleaned up
nivida Aug 29, 2024
4272435
checkOwner if inverted.. looks cleaner
nivida Aug 29, 2024
e9d11dd
remove extra check
novaknole Aug 29, 2024
b647372
counters equal to 1 instead of ++
novaknole Aug 29, 2024
4b66659
not required var removed in ownerAuth modifier
nivida Aug 29, 2024
9393e16
assertions with error types updated for permission-manager.ts
nivida Aug 30, 2024
38d6b39
_flags argument removed from ownerAuth cause it is no longer in usage
nivida Aug 30, 2024
6b54964
PM fixes and test cases added for PM.grant
nivida Sep 2, 2024
5c06c3c
missing expectation added to PM.grant test cases
nivida Sep 2, 2024
b8b9940
test cases for grantWithCondition added
nivida Sep 2, 2024
67aff37
revoke test cases extended
nivida Sep 2, 2024
f707b69
undelegate cases added
nivida Sep 2, 2024
67b7b12
PM applyTarget methods updated and related test cases extended
nivida Sep 3, 2024
4fbc63f
PM.addOwner fixed
nivida Sep 3, 2024
8609cf1
tests added for PM.addOwner
nivida Sep 3, 2024
600d129
PM.removeOwner test cases added
nivida Sep 3, 2024
e6c717c
prettier run
nivida Sep 3, 2024
4254ecb
codestyle PM tests
nivida Sep 3, 2024
e0c6bee
storage gap updated from 49 to 48
nivida Sep 3, 2024
e861691
PM.createPermission test cases added
nivida Sep 4, 2024
9c7751d
delegatePermission test cases added
nivida Sep 4, 2024
748fe35
undelegatePermission test cases added
nivida Sep 4, 2024
767f940
codestyle++
nivida Sep 4, 2024
0766c95
PM.createPermission test improved
nivida Sep 5, 2024
ab11975
PM.hasPermission renamed to _checkFlags and defined as private
nivida Sep 5, 2024
c62666c
apply target methods updated
nivida Sep 9, 2024
798bd66
permissionId updated in reverted error of plugin setup processor test…
nivida Sep 9, 2024
0dd7d63
not requried 'permHash' removed from delegations mapping
nivida Sep 9, 2024
9d85d81
Revert "permissionId updated in reverted error of plugin setup proces…
nivida Sep 9, 2024
1c793dc
Options enum removed and hardcoded flag values replaced with related …
nivida Sep 9, 2024
74e06e3
setAllowedContract added
nivida Sep 9, 2024
693161c
prettier run
nivida Sep 9, 2024
dd1b061
revert checks in plugin setup processor test cases updated for new pe…
nivida Sep 9, 2024
22feda8
test for apply singlle target updated for allowedContract case
nivida Sep 9, 2024
a98f8a5
clean up
nivida Sep 9, 2024
8984904
Feature/dao execute bruteforce approach (#607)
novaknole Sep 9, 2024
2a6783b
apply target method grantee fixed
novaknole Sep 10, 2024
88fc14c
unsafe allow delegatecall
novaknole Sep 10, 2024
3614f38
DAO.execute fixed and test cases added for it
nivida Sep 10, 2024
afe70be
add tests and fixes to dao (#608)
novaknole Sep 16, 2024
e688034
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
d0a83db
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
46c191a
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
cead54b
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
154eb40
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
6abaebf
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
c6479de
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
cc44e88
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
0b10859
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
0ceabf1
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
ab63589
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
dccda8a
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
d3a9978
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
10fd26b
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
ae3fa2d
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
bd934f4
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
352f8a2
Update packages/contracts/src/core/permission/PermissionManager.sol
novaknole Sep 17, 2024
921c2fb
fix typo
novaknole Sep 17, 2024
aaa72fc
ownerAuth as internal virtual function
novaknole Sep 17, 2024
8c658ea
add natspec for struct permission:
novaknole Sep 17, 2024
b1932bf
fix more tests and cleaner
novaknole Sep 17, 2024
4ec5af9
fix more tests and cleaner (#609)
novaknole Sep 17, 2024
d8109f1
Feature/fix and improve tests (#610)
clauBv23 Sep 24, 2024
fc06bff
conflicts fixed
novaknole Sep 24, 2024
b981a6f
Feature/fix apply methods (#611)
novaknole Sep 25, 2024
0e070da
executor interface (#612)
novaknole Sep 27, 2024
c5d8db6
fix tests and typechain + loop (#613)
novaknole Sep 29, 2024
4bb5752
modified daofactory
novaknole Sep 30, 2024
f899d79
native eth transfer handling + more tests
novaknole Oct 2, 2024
c888290
add virtual keywords to PM
novaknole Oct 2, 2024
5731b7b
some changes (#614)
novaknole Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading