Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP 🚧 feature: new pm sop #603

Closed
wants to merge 36 commits into from
Closed

WIP 🚧 feature: new pm sop #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
3b56109
first iteration
Jul 24, 2024
6978136
oe
Jul 24, 2024
020f551
iterations
Jul 30, 2024
cb4fbbb
Removed foundry-rs/forge-std
Aug 6, 2024
8541155
implement new permission manager with first iteration
novaknole Aug 16, 2024
c3ef8e0
latest requirements applied in pseudo code for PM
Aug 16, 2024
b7df646
delay logic and root fallback added to pseudo code/poc
Aug 19, 2024
5c84c0a
copy&pasta mistake
nivida Aug 19, 2024
bb8e66f
typo fix
nivida Aug 19, 2024
c04c62e
code duplications removed and started to finalize this pseudo code
nivida Aug 20, 2024
a1d9bbc
moved mappings to the top of the Permission struct for cleaner code w…
nivida Aug 20, 2024
c876ee2
small clean up of the poc
nivida Aug 20, 2024
2fae9d7
naming improved
nivida Aug 20, 2024
d682914
TODO note added and hasPermission simplified
nivida Aug 20, 2024
ad53659
delegatePermission updated
nivida Aug 20, 2024
52a3765
owner.permission renamed to owner.flags and function args checked
nivida Aug 20, 2024
25bf273
implicit memory def in hasPermission
nivida Aug 20, 2024
94c3d23
fix couple of bugs
novaknole Aug 21, 2024
255a2e0
combine permissions fixed
novaknole Aug 21, 2024
7d244f1
Options array replaced with flags to have the code more efficient
nivida Aug 21, 2024
ee50021
Instead of using uint8 directly it is better of course to use the Opt…
nivida Aug 21, 2024
6902b04
permission handling in applySingleTargetPermissions and applyMultiTar…
nivida Aug 21, 2024
7df3527
small clean up and removed the TODO for implementing an private metho…
nivida Aug 21, 2024
43805ff
fix flag bit mask comparison
novaknole Aug 21, 2024
f108436
apply* methods updated in PM
nivida Aug 21, 2024
9d5e862
Merge branch 'feature/new-pm-sop' of github.com:aragon/osx into featu…
nivida Aug 21, 2024
6e92f12
Added missing flags check to PM.removeOwner
nivida Aug 21, 2024
09ea1b1
typo removed (flagss -> flags)
nivida Aug 21, 2024
7852adb
clean-up
nivida Aug 21, 2024
c395b47
typo
nivida Aug 21, 2024
0623524
redesign PM with implicit freeze
novaknole Aug 27, 2024
71bb954
clean up and todo's added
nivida Aug 28, 2024
359daf7
roleHash removed and replaced with permissionHash
nivida Aug 28, 2024
9780814
delegation hash clean up
nivida Aug 28, 2024
ae5217f
clean up
nivida Aug 28, 2024
53d3894
Events added for add/removeOwner and delegate/undelegatePermission
nivida Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading