Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: switch the parameter order in the MinApprovalsOutOfBounds error in the Multisig #580

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix: switch the parameter order in the MinApprovalsOutOfBounds error in the Multisig #580

merged 1 commit into from
Apr 30, 2024

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Apr 29, 2024 •
edited by heueristik
Loading

Description

Fix revert params order in removeAddressesfunction

Task ID: OS-1299

Type of change

See the framework lifecycle in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.

@josemarinas josemarinas requested a review from heueristik April 29, 2024 08:40
heueristik
heueristik approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josemarinas josemarinas merged commit 6f27f30 into develop Apr 30, 2024
24 checks passed
@josemarinas josemarinas deleted the fix/OS-1299-reverted-argument-order-in-error-MinApprovalsOutOfBounds branch April 30, 2024 07:54
@heueristik heueristik changed the title fix: multisig removeAddresses revert param order fix: switch the parameter order in the MinApprovalsOutOfBounds error Apr 30, 2024
@heueristik heueristik changed the title fix: switch the parameter order in the MinApprovalsOutOfBounds error fix: switch the parameter order in the MinApprovalsOutOfBounds error in the Multisig Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordaniza jordaniza jordaniza approved these changes

@heueristik heueristik heueristik approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josemarinas @heueristik @jordaniza