-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/subgraph changes only #560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've read every file but haven't done a manual diff. This looks sensible but once we merge we should pull and run a test locally just to be sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is missing is the QA url.
please deploy the subgraph and provide the playground link as QA
Description
Only includes files that have changed on develop compared to main branch. This is to ensure that we still have the latest subgraph on main.
Please, see the file changes very carefully. Also, yarn.lock contains lots of changes which you might find it surprising. The yarn.lock looks like this because it contains everything from main branch's yarn lock + current branch's yarn.lock. Would be also good to go through with it just to be safe.
Task ID: OS-1180
QA: https://subgraphs.alchemy.com/subgraphs/984/versions/16039
Type of change
See the framework lifecylce in
packages/contracts/docs/framework-lifecycle
to decide what kind of change this pull request is.Checklist:
CHANGELOG.md
file in the root folder.DEPLOYMENT_CHECKLIST
file in the root folder.UPDATE_CHECKLIST
file in the root folder.