fix: updated typings in HRE declaration and type errors in helpers #536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed HRE extension compiler warnings: changed module exports from
hardhat/types
->hardhat/types/runtime
. This also fixes type errors in all deploy scripts.Added casting to fix 2 errors in the HH config and the networks file. I believe these are safe casts but we should discuss about having 2 separate
SupportedNetworks
enums when really we should have 1 coming from the commons.Removed Arbitrum Goerli and added base and arb sepolia to the networks, to align with supported networks and thus allow us to correctly index the networks in hardhat.config.
The only oddity was having to add a chai listener for defi wonderland. This was required for me to run the test suite so would appreciate a sanity check on why that might be.
This addresses 2 tickets:
OS-1037
OS-1038
Type of change
Checklist:
CHANGELOG.md
file in the root folder.DEPLOYMENT_CHECKLIST
file in the root folder.UPDATE_CHECKLIST
file in the root folder.