Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated typings in HRE declaration and type errors in helpers #536

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

jordaniza
Copy link

@jordaniza jordaniza commented Feb 12, 2024

Description

Fixed HRE extension compiler warnings: changed module exports from hardhat/types -> hardhat/types/runtime. This also fixes type errors in all deploy scripts.

Added casting to fix 2 errors in the HH config and the networks file. I believe these are safe casts but we should discuss about having 2 separate SupportedNetworks enums when really we should have 1 coming from the commons.

Removed Arbitrum Goerli and added base and arb sepolia to the networks, to align with supported networks and thus allow us to correctly index the networks in hardhat.config.

The only oddity was having to add a chai listener for defi wonderland. This was required for me to run the test suite so would appreciate a sanity check on why that might be.

This addresses 2 tickets:

OS-1037
OS-1038

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@Rekard0 Rekard0 merged commit 3cf4160 into develop Feb 14, 2024
18 checks passed
@Rekard0 Rekard0 deleted the fix/type-errors-hh-config branch February 14, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants