Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: use osx-commons-subgraph #520

Merged
merged 9 commits into from
Jan 26, 2024
Merged

Add: use osx-commons-subgraph #520

merged 9 commits into from
Jan 26, 2024

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Jan 10, 2024 •
edited by jira bot
Loading

Description

This PR aims to import the package osx-commons-subgraph. This package includes id generation functions that will be used all over the repo.

Task ID: OS-737

Type of change

See the framework lifecylce in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@josemarinas josemarinas force-pushed the f/OS-737-use-subgraph-commons-in-osx branch from a197661 to 211ecb1 Compare January 11, 2024 09:33
@josemarinas josemarinas marked this pull request as ready for review January 11, 2024 10:31
@Rekard0 Rekard0 requested a review from banasa44 January 15, 2024 10:34
heueristik
heueristik reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@josemarinas josemarinas merged commit 78e422f into develop Jan 26, 2024
17 checks passed
@novaknole novaknole deleted the f/OS-737-use-subgraph-commons-in-osx branch November 5, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

@banasa44 banasa44 Awaiting requested review from banasa44

Assignees
No one assigned
Labels
subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josemarinas @Rekard0 @heueristik