Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: signalling proposal subgraph change #503

Merged
merged 13 commits into from
Nov 23, 2023
Merged

refactor: signalling proposal subgraph change #503

merged 13 commits into from
Nov 23, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Nov 15, 2023 •
edited
Loading

Description

Task ID: OS-855

Test subgraph: https://subgraph.satsuma-prod.com/aragon/osx-michael-baseGoerli/playground

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@heueristik heueristik force-pushed the feature/OS-855-signalling-proposal-subgraph-change branch from 0462d8a to 13558cc Compare November 15, 2023 18:06
@heueristik heueristik marked this pull request as ready for review November 22, 2023 14:26
@heueristik heueristik added the subgraph:deploy Deploys subgraph to all networks if package.json's version is bumped label Nov 23, 2023
@heueristik heueristik requested a review from Rekard0 November 23, 2023 11:48
Rekard0
Rekard0 previously approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! apart from the minor suggestion

@heueristik heueristik merged commit c990310 into develop Nov 23, 2023
13 checks passed
@heueristik heueristik deleted the feature/OS-855-signalling-proposal-subgraph-change branch November 23, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemarinas josemarinas josemarinas approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

Assignees
No one assigned
Labels
subgraph:deploy Deploys subgraph to all networks if package.json's version is bumped subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @Rekard0 @josemarinas