refactor: use osx-commons #501

heueristik · 2023-11-13T17:34:46Z

Description

Task ID: OS-843

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

I have selected the correct base branch.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
My changes generate no new warnings.
Any dependent changes have been merged and published in downstream modules.
I ran all tests with success and extended them if necessary.
I have updated the CHANGELOG.md file in the root folder.
I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
I have updated the UPDATE_CHECKLIST file in the root folder.

This reverts commit 80c1468.

…ypos

…2fb27

mathewmeconry

Next time please do only move the files and do the necessary changes to make it work and include the optimizations in a followup pull.
This makes it easier to review and figure out if and how the logic changed

packages/contracts/npm/artifacts.ts

packages/contracts/src/framework/dao/DAOFactory.sol

packages/contracts/src/package.json

packages/contracts/src/test/plugin/Cloneable/PluginCloneableMock.sol

packages/contracts/test/plugins/governance/majority-voting/token/token-voting.ts

packages/contracts/test/plugins/governance/multisig/multisig-constants.ts

packages/contracts/test/test-utils/psp/wrappers.ts

packages/contracts/utils/storage.ts

heueristik · 2024-01-09T14:01:48Z

/mythx partial standard

…mmons

heueristik · 2024-01-11T18:05:38Z

Next time please do only move the files and do the necessary changes to make it work and include the optimizations in a followup pull.

You are right. When I had to remove some helpers, I couldn't keep my feet still. I pledge to do better

packages/contracts/src/test/plugins/MajorityVotingMock.sol

Rekard0

LGTM!

github-actions bot added the contracts label Nov 13, 2023

heueristik added 22 commits December 20, 2023 11:40

refactor: use osx-commons

0ecaa9b

refactor: remove proxy helper

e09f7f8

refactor: remove redundant tests

e00c6b4

refactor: replace helpers

4e71b1f

refactor: exclude files that are being moved from compilation

884ad1a

Revert "refactor: remove proxy helper"

b06e5ee

This reverts commit 80c1468.

fix: missed replacing a getInterfaceId

f05b5d6

refactor: removed redundant import

da7f7d5

fix: missed replacing a getInterfaceId

3d2dc7e

revert: deployWithProxy replacement

6b55f64

revert: readStorage replacement

2c01e55

fix: replaced missed findEvent

32b9694

wip

910a061

revert: file removals

84f0d99

fix: imports

d83b9e7

refactor: rename GovernanceERC20Mock to TestGovernanceERC20 and fix t…

125c91f

…ypos

refactor: remove timestampIn usage

0d70662

refactor: remove hardhat-time dependency

83bcec4

test: unskip test

94d84e4

refactor: use time helpers

6177729

fix: explicitly cast to IDAO

0030509

refactor: move over plugin and plugin setups as well as permissions 2…

9506965

…2fb27

heueristik force-pushed the feature/use-osx-commons branch from 32c4dac to 9506965 Compare December 20, 2023 14:59

github-actions bot added the subgraph label Dec 20, 2023

heueristik changed the title ~~refactor: use osx-commons~~ WIP: refactor: use osx-commons Dec 20, 2023

heueristik added 4 commits December 21, 2023 09:34

test: added missing test import

156fdba

revert: reintroduce MajorityVotingMock

d7c08ea

refactor: moved events

0d1fe7d

refactor: remove error.ts constants

b96e59f

mathewmeconry suggested changes Jan 9, 2024

View reviewed changes

heueristik added 3 commits January 11, 2024 10:06

WIP

7a928d6

fix: imports

5d5b145

Merge remote-tracking branch 'origin/develop' into feature/use-osx-co…

d72c7a7

…mmons

heueristik marked this pull request as ready for review January 11, 2024 17:09

build: remove artifact that is now part of osx-commons-contracts

06e399d

heueristik changed the title ~~WIP: refactor: use osx-commons~~ refactor: use osx-commons Jan 11, 2024

heueristik added 5 commits January 11, 2024 18:49

fix: awaits

599b498

fix: remove redundant catch

1b575a1

docs: removed todo

8ca3b48

revert: redundant IDAO typecast

a3e9c63

fix: missing awaits

e10bf74

heueristik requested review from mathewmeconry and Rekard0 January 11, 2024 18:05

heueristik added 2 commits January 12, 2024 09:31

fix: test fail due to altered error message

c373f5e

build: remove wrong dependency

ee11e74

mathewmeconry previously approved these changes Jan 12, 2024

View reviewed changes

Rekard0 reviewed Jan 14, 2024

View reviewed changes

packages/contracts/src/test/plugins/MajorityVotingMock.sol Outdated Show resolved Hide resolved

Rekard0 previously approved these changes Jan 14, 2024

View reviewed changes

chore: maintained changelog and checklists

b9bebf8

heueristik dismissed stale reviews from Rekard0 and mathewmeconry via b9bebf8 January 15, 2024 08:49

heueristik requested review from Rekard0 and josemarinas January 15, 2024 08:54

Rekard0 approved these changes Jan 15, 2024

View reviewed changes

josemarinas approved these changes Jan 15, 2024

View reviewed changes

heueristik merged commit d7e9ad0 into develop Jan 15, 2024

heueristik deleted the feature/use-osx-commons branch January 15, 2024 09:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: use osx-commons #501

refactor: use osx-commons #501

heueristik commented Nov 13, 2023 •

edited

Loading

mathewmeconry left a comment

heueristik commented Jan 9, 2024

heueristik commented Jan 11, 2024

Rekard0 left a comment

refactor: use osx-commons #501

refactor: use osx-commons #501

Conversation

heueristik commented Nov 13, 2023 • edited Loading

Description

Type of change

Checklist:

mathewmeconry left a comment

Choose a reason for hiding this comment

heueristik commented Jan 9, 2024

heueristik commented Jan 11, 2024

Rekard0 left a comment

Choose a reason for hiding this comment

heueristik commented Nov 13, 2023 •

edited

Loading