Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(OS-798): fixes 2 bugs in subgraph and npm releated workflows #491

Merged
merged 2 commits into from
Oct 25, 2023
Merged

ci(OS-798): fixes 2 bugs in subgraph and npm releated workflows #491

merged 2 commits into from
Oct 25, 2023

Conversation

mathewmeconry
Copy link
Contributor

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-?

Type of change

See the framework lifecylce in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@mathewmeconry
ci: wrong comparison in npm-release workflow
ba26f94
@mathewmeconry
ci: possible fix for subgraph deploy issue
e49a249 
updating the changelog requires a commit that needs to be signed, github
actions cannot do that easily. this is a possible solution for this
problem
@mathewmeconry mathewmeconry added the subgraph:deploy Deploys subgraph to all networks if package.json's version is bumped label Oct 25, 2023
@mathewmeconry mathewmeconry requested a review from Rekard0 October 25, 2023 14:51
@mathewmeconry mathewmeconry changed the title Fix/subgraph deploy workflow ci: fixes 2 bugs in subgraph and npm releated workflows Oct 25, 2023
@mathewmeconry mathewmeconry changed the title ci: fixes 2 bugs in subgraph and npm releated workflows ci(OS-798): fixes 2 bugs in subgraph and npm releated workflows Oct 25, 2023
@mathewmeconry mathewmeconry merged commit 4f9efb4 into develop Oct 25, 2023
10 checks passed
@mathewmeconry mathewmeconry deleted the fix/subgraph_deploy_workflow branch October 25, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

Assignees
No one assigned
Labels
subgraph:deploy Deploys subgraph to all networks if package.json's version is bumped
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathewmeconry @Rekard0