Skip to content

Conversation

Rekard0
Copy link
Contributor

@Rekard0 Rekard0 commented Oct 23, 2023

Description

Task ID: OS-784

For QA: https://app.satsuma.xyz/subgraphs/750/versions/5531
query:

{
  tokenVotingMembers(where: {plugin: "0x72b1d7ce9748adb10ea7dbd5f9e0456995b02e05"} ) {
    address
    balance
    votingPower
      delegatee {
        address
      }
      delegators {
        address
        balance  
      }
    } 
}

Type of change

See the framework lifecylce in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@Rekard0 Rekard0 requested review from heueristik and josemarinas and removed request for heueristik October 23, 2023 11:39
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. LGTM otherwise

@Rekard0 Rekard0 requested a review from mathewmeconry October 25, 2023 09:41
@Rekard0 Rekard0 merged commit 465e3a3 into develop Oct 25, 2023
@Rekard0 Rekard0 deleted the fix/OS-784_delegatee-bug branch October 25, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants