Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: add prettier plugin to sort imports #487

Merged
merged 4 commits into from
Oct 19, 2023
Merged

style: add prettier plugin to sort imports #487

merged 4 commits into from
Oct 19, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Oct 18, 2023 •
edited
Loading

Description

This PR adds project-wide format checks for all files matching this pattern '**/*.{js,json,md,sol,ts,yml}'.

Task ID: OS-594

Type of change

  • formatting and style

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@heueristik heueristik force-pushed the feature/prettier-import-sorting branch from 26e234a to 329e2e4 Compare October 18, 2023 14:22
@heueristik heueristik force-pushed the feature/prettier-import-sorting branch from 329e2e4 to 8cf16a7 Compare October 18, 2023 14:25
mathewmeconry
mathewmeconry suggested changes Oct 18, 2023
View reviewed changes
.github/workflows/style-check.yml Outdated Show resolved Hide resolved
@heueristik heueristik requested a review from Rekard0 October 19, 2023 08:10
Rekard0
Rekard0 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@heueristik heueristik merged commit 93c43e4 into develop Oct 19, 2023
3 checks passed
@heueristik heueristik deleted the feature/prettier-import-sorting branch October 19, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@mathewmeconry mathewmeconry mathewmeconry approved these changes

@josemarinas josemarinas Awaiting requested review from josemarinas

Assignees
No one assigned
Labels
contracts subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @mathewmeconry @Rekard0