Skip to content

Commit

Permalink
fix: wrong import, missing await, incorrect comment (#526)
Browse files Browse the repository at this point in the history
* fix: wrong import path

* docs: wrong NatSpec

* fix: missing await
  • Loading branch information
heueristik authored Feb 6, 2024
1 parent 35c066e commit c559bfe
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/contracts/hardhat.config.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import networks, {ContractsNetworkConfig} from './networks';
import {AragonPluginRepos, TestingFork} from './utils/types';
import {AragonPluginRepos, TestingFork} from './types/hardhat';
import {NetworkConfigs} from '@aragon/osx-commons-configs';
import '@nomicfoundation/hardhat-chai-matchers';
import '@nomicfoundation/hardhat-network-helpers';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ contract PluginSetupProcessor is ProtocolVersion {

/// @notice Applies the permissions of a prepared update of an UUPS upgradeable proxy contract to a DAO.
/// @param _dao The address of the updating DAO.
/// @param _params The struct containing the parameters for the `applyInstallation` function.
/// @param _params The struct containing the parameters for the `applyUpdate` function.
function applyUpdate(
address _dao,
ApplyUpdateParams calldata _params
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ describe('ENSSubdomainRegistrar', function () {

it('reverts if the approval of the registrar is removed', async () => {
// Initialize the registrar with the 'test' domain
registrar.initialize(
await registrar.initialize(
managingDao.address,
ens.address,
ensDomainHash('test')
Expand Down

0 comments on commit c559bfe

Please sign in to comment.