test: check for correct value instead non-reverting call

aragon · Sep 1, 2023 · 89817bd · 89817bd
1 parent c287c05
commit 89817bd
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/packages/contracts/test/core/dao/dao.ts b/packages/contracts/test/core/dao/dao.ts
@@ -1325,10 +1325,12 @@ describe('DAO', function () {
       expect(await mockCondition.answer()).to.be.true;
 
       // Any caller can validate signatures using this condition now.
-      expect(await dao.connect(caller).isValidSignature(hash, signature)).to.not
-        .be.reverted;
-      expect(await dao.connect(otherCaller).isValidSignature(hash, signature))
-        .to.not.be.reverted;
+      expect(
+        await dao.connect(caller).isValidSignature(hash, signature)
+      ).to.equal(VALID_ERC1271_SIGNATURE);
+      expect(
+        await dao.connect(otherCaller).isValidSignature(hash, signature)
+      ).to.equal(VALID_ERC1271_SIGNATURE);
 
       // Set the mock condition to answer false.
       await mockCondition.setAnswer(false);