-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Aragon Agent Guide #167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unixpi
force-pushed
the
sach-agent-guide
branch
6 times, most recently
from
June 1, 2019 12:56
2d324bd
to
9c4ef61
Compare
add introduction to agent app guide update agent app guide: edit intro and add prereq section update guides-agent-app.md: minor edits update guides-agent-app.md: minor edits
minor edit + setup next section: Installing the Agent app tone edit tone edit flesh out 'installing aragonCLI' subsection edit yesterday's work
flesh out step 3: setting permissions section add dao apps tables Update Step 3: Setting permissions Minor minor edit
Update dao acl explanation + edit structure Minor edit structure edit structure edit minor edit
Minor edit Setup: Step 3 edits Setup: Step 4 edits Edits Setup: Step 4 edits Use case A edits Use case A edits Use case A edit Use case A edit Use case A edit Use case A edits Use case A edits Use case A edits Use case A edits Use case A edits Text + style edits Style edit Tidy up a few things + add notes Minor edit Minor edit Edits Edits Edits Edits minor edits minor edit minor edits minor edit minor edit Use case A: minor edits edits Minor edit Add images + edits Use case A: minor edits Use case A: edits Setup: steps 1 + 2 edits Setup: step 3 edits Setup: step 3 edits Setup: step 3 edits Setup: step 4 edits Minor edits explain dao exec Edit dao exec explanation Explain Token Manager's Mint method minor edit minor edit Add images of Agent guide Add images to Setup step 2 Adjust image dimensions Adjust image dimensions Add text explaining images Edits Edit image text style Minor edit Setup section 3 style edits Edits Fix typo minor edits + notes to self Add small conclusion to Use case A Explain dao act Add metadata: id, title, and sidebar_label Minor edit Use case A conclusion edit Edits Add image highlighting vote id Add link to image highlighting vote id Update voter id image caption Update voter id image caption Update voter id image caption Add more images Add links to new images Add explanations to images highlighting permissions Minor edit Edits Correct link Minor edit Minor edit Minor edits Minor edit Remove height from images to allow accurate rescaling on browser resize
0xGabi
reviewed
Jun 1, 2019
0xGabi
reviewed
Jun 1, 2019
0xGabi
reviewed
Jun 1, 2019
0xGabi
reviewed
Jun 1, 2019
Update: added a prerequisite section for those who've never interacted with an Aragon app before. |
Fix typo Co-Authored-By: Gabriel Garcia <[email protected]>
0xGabi
reviewed
Jun 1, 2019
0xGabi
reviewed
Jun 1, 2019
0xGabi
reviewed
Jun 1, 2019
0xGabi
reviewed
Jun 1, 2019
0xGabi
reviewed
Jun 1, 2019
0xGabi
reviewed
Jun 1, 2019
0xGabi
reviewed
Jun 1, 2019
0xGabi
reviewed
Jun 1, 2019
izqui
reviewed
Jun 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating the feedback @hackingclimate! One minor comment
0xGabi
reviewed
Jun 12, 2019
0xGabi
reviewed
Jun 12, 2019
0xGabi
reviewed
Jun 12, 2019
0xGabi
reviewed
Jun 12, 2019
0xGabi
reviewed
Jun 12, 2019
0xGabi
reviewed
Jun 12, 2019
0xGabi
reviewed
Jun 12, 2019
0xGabi
reviewed
Jun 12, 2019
Co-Authored-By: Gabriel Garcia <[email protected]>
Co-Authored-By: Gabriel Garcia <[email protected]>
Co-Authored-By: Gabriel Garcia <[email protected]>
Co-Authored-By: Gabriel Garcia <[email protected]>
Co-Authored-By: Gabriel Garcia <[email protected]>
Co-Authored-By: Gabriel Garcia <[email protected]>
Co-Authored-By: Gabriel Garcia <[email protected]>
Include the new changes of last aragonCLI version (remove --apm.ipfs.rpc global option)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone. This is a draft PR for async comments. It complete part of #115
A couple of thoughts:
I'm pretty happy with Part 1 -- the in depth guide on how to install the Agent app with aragonCLI. Though it's possible I've misunderstood a couple of things about how
--apm.ipfs.rpc
andaragon ipfs
work (see step 2).For Part 2 -- show a good use case of using the Agent app -- I've chosen to go with @sohkai 's suggestion: Voting in another org. The other suggestions (interacting with Uniswap and opening a Maker CDP) seemed harder to do on Rinkeby. However I think we should also cover them in the guide. I've added them as section titles (along with @luisivan 's Aragon Trust) at the end.
Update: after discussing with @0xGabi, replaced the Uniswap use case with Compound (since there is a Compound testnet).
Thanks for taking the time to read. Looking forward to hearing your thoughts!
P.S. I had a lot of fun figuring this out. Even with all the issues that come with being on the bleeding edge 😉. It really is a beautiful design.