Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logger interface #100

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Add logger interface #100

merged 2 commits into from
Apr 3, 2024

Conversation

Fabricevladimir
Copy link
Contributor

  • adds a logger interface with a concrete implementation that makes usage of the console
  • updates gitignore to include vscode editor setting

xavikh
xavikh approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@xavikh xavikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fabricevladimir Fabricevladimir merged commit b9cdca3 into main Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavikh xavikh xavikh approved these changes

@brickpop brickpop Awaiting requested review from brickpop

@carlosgj94 carlosgj94 Awaiting requested review from carlosgj94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fabricevladimir @xavikh