fix(PE-7040): updated weight names #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtfiedler
changed the title
dtfiedler
force-pushed
the
PE-7040-updated-weight-names
branch
from
f776cb0 to
6ecaa24
Compare
fedellen
reviewed
Jan 29, 2025
Comment on lines
+244
to
+250
| // @deprecated - use `gatewayPerformanceRatio` instead | ||
| gatewayRewardRatioWeight: number; | ||
| // @deprecated - use `observerPerformanceRatio` instead | ||
| observerRewardRatioWeight: number; | ||
| gatewayPerformanceRatio: number; | ||
| observerPerformanceRatio: number; |
There was a problem hiding this comment.
in the method, we could duplicated this deprecated value to prevent any backwards compatiblity issues. at least until release 4.0.0
There was a problem hiding this comment.
the contract will continue to provide these values for now. pre-mainnet we can prep and release a v4 with the final types
dtfiedler
added a commit
to ar-io/ar-io-network-process
that referenced
this pull request
Jan 31, 2025
…tioWeight with gatewayPerformanceRatio and observerPerformanceRatio (#341) Swap out the attribute name. for the handlers we'll support the old ones until the SDK and network portal are updated. ar-io/ar-io-sdk#367
dtfiedler
force-pushed
the
PE-7040-updated-weight-names
branch
from
6ecaa24 to
a4aaf38
Compare
fedellen
approved these changes
Jan 31, 2025
|
🎉 This PR is included in version 3.4.1-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ar-io/ar-io-network-process#341