chore(test): move unit tests next to implementations

ar-io · Feb 4, 2025 · 7e1fef1 · 7e1fef1
1 parent 0cef900
commit 7e1fef1
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 9 deletions.
diff --git a/tests/unit/ant.test.ts → src/types/ant.test.ts b/tests/unit/ant.test.ts → src/types/ant.test.ts
@@ -7,7 +7,7 @@ import {
   AntInfoSchema,
   AntStateSchema,
   isAoANTState,
-} from '../../src/types/ant.js';
+} from './ant.js';
 
 const stub_address = 'valid-address'.padEnd(43, '1');
 

diff --git a/src/types/ant.ts b/src/types/ant.ts
@@ -208,6 +208,7 @@ export interface AoANTWrite extends AoANTRead {
   removeController: AoWriteAction<{ controller: WalletAddress }>;
   /** @deprecated Use setUndernameRecord instead for undernames, and setBaseNameRecord instead for the top level name (e.g. "@") */
   setRecord: AoWriteAction<AoANTSetUndernameRecordParams>;
+  /** @deprecated Use removeUndernameRecord instead for undernames */
   removeRecord: AoWriteAction<{ undername: string }>;
   setBaseNameRecord: AoWriteAction<AoANTSetBaseNameRecordParams>;
   setUndernameRecord: AoWriteAction<AoANTSetUndernameRecordParams>;

diff --git a/tests/unit/token.test.ts → src/types/token.test.ts b/tests/unit/token.test.ts → src/types/token.test.ts
@@ -1,7 +1,7 @@
 import { strict as assert } from 'node:assert';
 import { describe, it } from 'node:test';
 
-import { ARIOToken, mARIOToken } from '../../src/types/token.js';
+import { ARIOToken, mARIOToken } from './token.js';
 
 describe('ARIOToken', () => {
   it('should throw an error on invalid input', () => {

diff --git a/tests/unit/b64.test.ts → src/utils/b64.test.ts b/tests/unit/b64.test.ts → src/utils/b64.test.ts
@@ -1,7 +1,7 @@
 import { strict as assert } from 'node:assert';
 import { describe, it } from 'node:test';
 
-import { fromB64Url, getRandomText, toB64Url } from '../../src/utils/base64.js';
+import { fromB64Url, getRandomText, toB64Url } from './base64.js';
 
 describe('b64utils', () => {
   it('should convert various strings to base64url and back', () => {
@@ -16,8 +16,12 @@ describe('b64utils', () => {
     ];
     for (const str of testStrings) {
       const encoded = toB64Url(Buffer.from(str));
-      const decoded = Buffer.from(fromB64Url(encoded)).toString();
-      assert.strictEqual(decoded, str, `Failed for string: ${str}`);
+      const decoded = fromB64Url(encoded);
+      assert.deepStrictEqual(
+        decoded,
+        Buffer.from(str),
+        `Failed for string: ${str}`,
+      );
     }
   });
   it('should convert various buffers to base64url and back', () => {

diff --git a/tests/unit/utils.test.ts → src/utils/utils.test.ts b/tests/unit/utils.test.ts → src/utils/utils.test.ts
@@ -1,8 +1,8 @@
 import { strict as assert } from 'node:assert';
 import { describe, it } from 'node:test';
 
-import { pruneTags } from '../../src/utils/arweave.js';
-import { errorMessageFromOutput } from '../../src/utils/index.js';
+import { pruneTags } from './arweave.js';
+import { errorMessageFromOutput } from './index.js';
 
 describe('pruneTags', () => {
   it('should remove tags with undefined values', () => {

diff --git a/tests/e2e/esm/index.test.ts b/tests/e2e/esm/index.test.ts
@@ -504,7 +504,10 @@ describe('e2e esm tests', async () => {
       assert(Array.isArray(balances.items));
       balances.items.forEach((wallet) => {
         assert(typeof wallet.address === 'string');
-        assert(typeof wallet.balance === 'number');
+        assert(
+          typeof wallet.balance === 'number',
+          `Balance for ${wallet.address} is not a number: ${wallet.balance}`,
+        );
       });
     });
 
@@ -1093,7 +1096,13 @@ describe('e2e esm tests', async () => {
       it('should be able to get the ANT records', async () => {
         const records = await ant.getRecords();
         assert.ok(records);
-        // TODO: check enforcement of alphabetical order with '@' first
+        for (const record of Object.values(records)) {
+          assert(typeof record.transactionId === 'string');
+          assert(typeof record.ttlSeconds === 'number');
+          if (record.priority) {
+            assert(typeof record.priority === 'number');
+          }
+        }
       });
 
       it('should be able to get a @ record from the ANT', async () => {