chore(flags): change scope/event flag parsers #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store the scope and event operator (non expression) in the parser stage, avoiding re-parsing them in the policy build stage. parseEventFlag now returns a slice of eventFlag instead of a single eventFlag. This also adds a new related unit tests.
josedonizetti
approved these changes
Aug 22, 2023
josedonizetti
pushed a commit
to josedonizetti/tracee
that referenced
this pull request
Sep 1, 2023
Store the scope and event operator (non expression) in the parser stage, avoiding re-parsing them in the policy build stage. parseEventFlag now returns a slice of eventFlag instead of a single eventFlag. This also adds a new related unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #3312
1. Explain what the PR does
f913456 chore(flags): change scope/event flag parsers
2. Explain how to test it
3. Other comments