fix: data source registration after NewEngine #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only maintain the latest release (right @yanivagman ?) @geyslan you're the release owner, up to you to approve, merge and cherry-pick. |
rafaeldtinoco
approved these changes
Jul 26, 2023
@NDStrahilevitz, I'm waiting tests pass to get this merged. |
Previously data sources could not be registered after the NewEngine call call and be used in signatures, due to the Init calls being made in NewEngine. Fix by moving the loadSignature and initial data source registers to a new Init method from NewEngine. In addition, export a method in tracee to prepare the builtin data sources provided out of the box.
NDStrahilevitz
force-pushed
the
fix/register_data_source_after_new
branch
from
eed3f60
to
d588ce8
Compare
geyslan
pushed a commit
to geyslan/tracee
that referenced
this pull request
Jul 27, 2023
Previously data sources could not be registered after the NewEngine call call and be used in signatures, due to the Init calls being made in NewEngine. Fix by moving the loadSignature and initial data source registers to a new Init method from NewEngine. In addition, export a method in tracee to prepare the builtin data sources provided out of the box. commit: efa0ec4 (main), cherry-pick
geyslan
added a commit
that referenced
this pull request
Jul 27, 2023
Previously data sources could not be registered after the NewEngine call call and be used in signatures, due to the Init calls being made in NewEngine. Fix by moving the loadSignature and initial data source registers to a new Init method from NewEngine. In addition, export a method in tracee to prepare the builtin data sources provided out of the box. commit: efa0ec4 (main), cherry-pick Co-authored-by: Nadav Strahilevitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3341
Needs backport into v0.16.0 and v0.17.0