[move-compiler-v2] Print a better error message for a string without b or x #14687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14687 +/- ##
=========================================
- Coverage 59.8% 59.8% -0.1%
=========================================
Files 851 851
Lines 207246 207266 +20
=========================================
+ Hits 124055 124056 +1
- Misses 83191 83210 +19 ☔ View full report in Codecov by Sentry. |
brmataptos
force-pushed
the
brm-issue-14364
branch
from
40ddded
to
fd0493f
Compare
vineethk
reviewed
Sep 19, 2024
| ┌─ tests/move_check/parser/constants_simple.move:16:29 | ||
| │ | ||
| 16 │ const C12: vector<u8> = "<empty>"; | ||
| │ ^ String literal must begin with b" (for a byte string) or h" (for a hex string) |
There was a problem hiding this comment.
I think we should break this test up, so that this new blocking (parse) error does not shadow the compile errors being showcased before.
| let loc = make_loc(file_hash, start_offset, start_offset); | ||
| return Err(Box::new(diag!( | ||
| Syntax::InvalidByteString, | ||
| (loc, "String literal must begin with b\" (for a byte string) or h\" (for a hex string)") |
There was a problem hiding this comment.
Hex strings are x"255" according to the Move book, not h"255". Fix here if this was a typo, else, we need to fix the Move book to say we also allow h"255".
|
|
||
| const C10: vector<u8> = b"<empty>"; | ||
| const C11: vector<u8> = x"deadbeef"; | ||
| const C12: vector<u8> = "<empty>"; |
There was a problem hiding this comment.
Could we also add one case of strings with some escape characters, e.g., "\"\x48".
There was a problem hiding this comment.
I did better than that, I added a case with a non-UTF character. We'll see how portable that one is.
| │ │ | ||
| │ Invalid call or operation in constant | ||
| error: invalid byte string | ||
| ┌─ tests/folding/constants_simple.move:16:29 |
There was a problem hiding this comment.
Same comment as before: split test to retain old error messages.
brmataptos
force-pushed
the
brm-issue-14364
branch
from
fd0493f
to
b9c9bff
Compare
brmataptos
commented
Sep 19, 2024
|
|
||
| const C10: vector<u8> = b"<empty>"; | ||
| const C11: vector<u8> = x"deadbeef"; | ||
| const C12: vector<u8> = "<empty>"; |
There was a problem hiding this comment.
I did better than that, I added a case with a non-UTF character. We'll see how portable that one is.
| ┌─ tests/move_check/parser/constants_simple.move:16:29 | ||
| │ | ||
| 16 │ const C12: vector<u8> = "<empty>"; | ||
| │ ^ String literal must begin with b" (for a byte string) or h" (for a hex string) |
| let loc = make_loc(file_hash, start_offset, start_offset); | ||
| return Err(Box::new(diag!( | ||
| Syntax::InvalidByteString, | ||
| (loc, "String literal must begin with b\" (for a byte string) or h\" (for a hex string)") |
| │ │ | ||
| │ Invalid call or operation in constant | ||
| error: invalid byte string | ||
| ┌─ tests/folding/constants_simple.move:16:29 |
vineethk
approved these changes
Sep 20, 2024
brmataptos
changed the title
brmataptos
force-pushed
the
brm-issue-14364
branch
from
0d30d79
to
8fb3bfb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
brmataptos
force-pushed
the
brm-issue-14364
branch
from
8fb3bfb
to
fb0b705
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14364.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Run by hand.
Key Areas to Review
There doesn't seem to be any way to recover from this sort of error. But at least we can help inform people when
they type "foo" instead of b"foo".
Checklist