Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ftux): when to ask for a git push #731

Merged
merged 11 commits into from
Feb 16, 2024
Merged

refactor(ftux): when to ask for a git push #731

merged 11 commits into from
Feb 16, 2024

Conversation

neurosnap
Copy link
Member

@neurosnap neurosnap commented Feb 14, 2024 •
edited
Loading

ftux-git-push.mp4

@neurosnap neurosnap changed the base branch from main to feat-ftux-github-integration February 14, 2024 18:13
@neurosnap neurosnap changed the title Refactor ftux push order refactor(ftux): when to ask for a git push Feb 15, 2024
@neurosnap neurosnap marked this pull request as ready for review February 15, 2024 16:06
@neurosnap neurosnap requested a review from joshraker February 15, 2024 16:06
joshraker
joshraker approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@joshraker joshraker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the final push/deploy instructions could be more clear/specific but not strongly enough to require it in this PR.

@neurosnap neurosnap merged commit be42979 into feat-ftux-github-integration Feb 16, 2024
3 checks passed
@neurosnap neurosnap deleted the refactor-ftux-push-order branch February 16, 2024 18:51
@neurosnap neurosnap restored the refactor-ftux-push-order branch February 21, 2024 15:27
@neurosnap neurosnap deleted the refactor-ftux-push-order branch February 21, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshraker joshraker joshraker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neurosnap @joshraker