Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): use elevated token when revoking all tokens #728

Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix(settings): use elevated token when revoking all tokens #728

merged 2 commits into from
Feb 9, 2024

Conversation

neurosnap
Copy link
Member

@neurosnap neurosnap commented Feb 9, 2024 •
edited
Loading

@neurosnap neurosnap changed the title fix(settings): use elevated token when logging out fix(settings): use elevated token when revoking all tokens Feb 9, 2024
@neurosnap neurosnap requested a review from almathew February 9, 2024 14:06
@joshraker
Copy link
Member

I tested this PR and it worked as expected.

  1. Login to CLI with password
  2. aptible apps works
  3. Login to UI with SSO
  4. Elevate into security settings
  5. Revoke all tokens
  6. aptible apps reports the token was revoked

I tested it on main to confirm I was able to reproduce the issue and was able to do so.

@neurosnap neurosnap requested review from joe-herman and removed request for almathew February 9, 2024 19:18
@neurosnap neurosnap merged commit 54c953d into main Feb 9, 2024
3 checks passed
@neurosnap neurosnap deleted the revoke-tokens-elevated branch February 9, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-herman joe-herman joe-herman approved these changes

@joshraker joshraker joshraker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neurosnap @joshraker @joe-herman