fix: blank env editor #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This maps closer to how it works in the CLI: it's additive.
|
Tested functionality; matched expectations. 👍 Added copy improvements: Noticed we show this text on the page, which should only be relevant during FTUX. Did not remove so as not to break behavior elsewhere:
|
|
Deferring to @almathew for reviewing and deciding on whether to take this approach. |
|
I'll 👍 once we've added Frank's updated language here https://aptible.slack.com/archives/C05CMUW3LHX/p1707434071436489?thread_ts=1707424541.084289&cid=C05CMUW3LHX |
almathew
reviewed
Feb 8, 2024
fancyremarker
force-pushed
the
blank-env-editor
branch
from
6237f84 to
fb67f55
Compare
almathew
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we showed all the environment variables which could cause some unintended side-effects and doesn't really map with how environment variables are set in Apps. This change aligns more closely with how the CLI functions: it's additive.
I also updated the explainer text to make it more clear how we parse our textarea.
