Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scale): redirect on success #724

Merged
merged 3 commits into from
Feb 9, 2024
Merged

fix(scale): redirect on success #724

merged 3 commits into from
Feb 9, 2024

Conversation

neurosnap
Copy link
Member

@neurosnap neurosnap requested a review from joshraker February 8, 2024 20:22
@joshraker
Copy link
Member

I'm not following what's causing the loader to trigger a success when we come back to the page but not when we first get there. Are we caching the loader or action somehow?

@joshraker
Copy link
Member

Confirmed the tests catch the regression

❯ npx vitest run src/app/test/*-scale.test.tsx

 RUN  v0.34.6 /Users/joshraker/git/aptible/app-ui

 ✓ src/app/test/database-detail-scale.test.tsx  (2 tests) 852ms
 ✓ src/app/test/app-detail-service-scale.test.tsx  (3 tests) 1039ms

 Test Files  2 passed (2)
      Tests  5 passed (5)
   Start at  13:01:32
   Duration  2.93s (transform 1.03s, setup 1.26s, collect 1.82s, tests 1.89s, environment 328ms, prepare 93ms)
❯ git checkout main src/ui/pages/*-scale.tsx
Updated 2 paths from 7bd832c
❯ npx vitest run src/app/test/*-scale.test.tsx

 RUN  v0.34.6 /Users/joshraker/git/aptible/app-ui

 ...

 Test Files  2 failed (2)
      Tests  2 failed | 3 passed (5)
   Start at  13:02:14
   Duration  3.24s (transform 1.05s, setup 1.34s, collect 1.83s, tests 2.15s, environment 341ms, prepare 97ms)

@neurosnap neurosnap merged commit acc0387 into main Feb 9, 2024
3 checks passed
@neurosnap neurosnap deleted the fix-scale-redirect branch February 9, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants