Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app/services autoscaling status column #705

Merged
merged 6 commits into from
Jan 30, 2024
Merged

app/services autoscaling status column #705

merged 6 commits into from
Jan 30, 2024

Conversation

joshraker
Copy link
Member

@joshraker joshraker commented Jan 26, 2024 •
edited
Loading

  • Adds an autoscaling status column on the app/services page if autoscaling is enabled on the Stack. The global services page (services by org) is unaffected.
  • Adds service sizing policies to the schema and updates existing pages to use it.
  • Adds the variant option to Pill to conform to our other elements.

Disabled:
Screenshot 2024-01-26 at 09 10 55

Enabled:
Screenshot 2024-01-26 at 09 13 18

Screenshot 2024-01-26 at 09 13 04

Open tasks:

@joshraker joshraker requested a review from neurosnap January 26, 2024 18:12
@joshraker joshraker marked this pull request as ready for review January 26, 2024 18:12
@joshraker
Copy link
Member Author

https://app.shortcut.com/aptible/story/21734/app-ui-display-autoscaling-enabled-disabled-on-app-services-page

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #21734: app-ui - Display autoscaling enabled/disabled on app / services page.

@joshraker joshraker changed the title app/services autoscaling status column [Blocked] app/services autoscaling status column Jan 26, 2024
neurosnap
neurosnap reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@neurosnap neurosnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice job! This was all setup perfectly. I only have one tiny comment at this point.

@joshraker joshraker requested a review from neurosnap January 29, 2024 15:50
@joshraker joshraker changed the title [Blocked] app/services autoscaling status column app/services autoscaling status column Jan 30, 2024
@joshraker joshraker merged commit 5c6d622 into main Jan 30, 2024
1 check passed
@joshraker joshraker deleted the vas-service-status branch January 30, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeclayallday joeclayallday joeclayallday approved these changes

@neurosnap neurosnap Awaiting requested review from neurosnap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshraker @neurosnap @joeclayallday